mirror/Odin
1
0 Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-10-09 22:32:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7594 from bplu4t2f/fix-7583

Browse Source 
Fix 7583: -strict-style requires comma before newline after proc parameters which have a default value.
This commit is contained in:
gingerBill authored and GitHub committed 2026-09-29 13:11:39 +01:00
2 parents bd4f2821e1 7f546546f7
commit 5a4e0de0cc
6 files changed
+34 -24
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/parser.cpp
+10
View File
@@ -5188,7 +5188,12 @@ gb_internal Ast *parse_field_list(AstFile *f, isize *name_count_, u32 allowed_fl
}
if (allow_token(f, Token_Eq)) {
// NOTE(bplu4t2f): We're usually at expr_level == 1 here, but the default value expr needs to be self-contained to ensure correct newline behavior after it.
isize previous_expr_level = f->expr_level;
f->expr_level = 0;
default_value = parse_expr(f, false);
GB_ASSERT(f->expr_level == 0);
f->expr_level = previous_expr_level;
if (!allow_default_parameters) {
syntax_error(f->curr_token, "Default parameters are only allowed for procedures");
default_value = nullptr;
@@ -5263,7 +5268,12 @@ gb_internal Ast *parse_field_list(AstFile *f, isize *name_count_, u32 allowed_fl
}
if (allow_token(f, Token_Eq)) {
// NOTE(bplu4t2f): We're usually at expr_level == 1 here, but the default value expr needs to be self-contained to ensure correct newline behavior after it.
isize previous_expr_level = f->expr_level;
f->expr_level = 0;
default_value = parse_expr(f, false);
GB_ASSERT(f->expr_level == 0);
f->expr_level = previous_expr_level;
if (!allow_default_parameters) {
syntax_error(f->curr_token, "Default parameters are only allowed for procedures");
default_value = nullptr;