mirror/Odin
1
0 Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-10-08 22:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Improve mixed order ternary type inference and poly-determination diagnostics

Browse Source
This commit is contained in:
gingerBill committed 2026-10-01 01:30:38 +01:00
1 parent 66111934c3
commit 7c8dfd4cff
2 files changed
+41 -14
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/check_expr.cpp
+17 -6
View File
@@ -10551,19 +10551,30 @@ gb_internal ExprKind check_ternary_if_expr(CheckerContext *c, Operand *o, Ast *n
Operand x = {Addressing_Invalid};
Operand y = {Addressing_Invalid};
check_expr_as_value_for_ternary(c, &x, te->x, type_hint);
node->viral_state_flags |= te->x->viral_state_flags;
if (te->y != nullptr) {
if (te->y == nullptr) {
check_expr_as_value_for_ternary(c, &x, te->x, type_hint);
node->viral_state_flags |= te->x->viral_state_flags;
error(node, "A ternary expression must have an else clause");
return kind;
}
if (type_hint == nullptr && arg_is_deferrable_untyped_expr(te->x)) {
check_expr_as_value_for_ternary(c, &y, te->y, nullptr);
node->viral_state_flags |= te->y->viral_state_flags;
Type *th = is_type_typed(y.type) ? y.type : nullptr;
check_expr_as_value_for_ternary(c, &x, te->x, th);
node->viral_state_flags |= te->x->viral_state_flags;
} else {
check_expr_as_value_for_ternary(c, &x, te->x, type_hint);
node->viral_state_flags |= te->x->viral_state_flags;
Type *th = type_hint;
if (type_hint == nullptr && is_type_typed(x.type)) {
th = x.type;
}
check_expr_as_value_for_ternary(c, &y, te->y, th);
node->viral_state_flags |= te->y->viral_state_flags;
} else {
error(node, "A ternary expression must have an else clause");
return kind;
}
if (te->x->viral_state_flags & ViralStateFlag_ContainsDeferredProcedure) {