mirror/Odin
1
0 Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-10-08 22:01:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7417 from kalsprite/foreign_sig_named_struct

Browse Source 
Fix segfault comparing two foreign declarations of the same symbol
This commit is contained in:
Jeroen van Rijn authored and GitHub committed 2026-08-22 03:11:27 +02:00
2 parents 082017cd2a c29596e88f
commit 830f41e280
5 files changed
+54 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/check_decl.cpp
+4 -4
View File
@@ -885,10 +885,10 @@ gb_internal bool signature_parameter_similar_enough(Type *x, Type *y) {
if (x_base->Struct.is_raw_union) {
return true;
}
if (x->Struct.fields.count == y->Struct.fields.count) {
for (isize i = 0; i < x->Struct.fields.count; i++) {
Entity *a = x->Struct.fields[i];
Entity *b = y->Struct.fields[i];
if (x_base->Struct.fields.count == y_base->Struct.fields.count) {
for (isize i = 0; i < x_base->Struct.fields.count; i++) {
Entity *a = x_base->Struct.fields[i];
Entity *b = y_base->Struct.fields[i];
bool similar = signature_parameter_similar_enough(a->type, b->type);
if (!similar) {
// NOTE(bill): If the fields are not similar enough, then stop.