From 0a201edbc1681ae9ddd5dea71d96cf836699466f Mon Sep 17 00:00:00 2001 From: Adam Honse Date: Thu, 17 Sep 2026 16:48:41 -0500 Subject: [PATCH] Fix a null pointer dereference in SendReply_PluginList --- NetworkServer.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/NetworkServer.cpp b/NetworkServer.cpp index 5306dc7e1..88d1d6019 100644 --- a/NetworkServer.cpp +++ b/NetworkServer.cpp @@ -3793,19 +3793,20 @@ void NetworkServer::SendReply_ServerString(NetworkClientInfo* client_info) void NetworkServer::SendReply_PluginList(NetworkClientInfo* client_info) { - unsigned int data_size = 0; - unsigned int data_ptr = 0; + unsigned int data_ptr = 0; + unsigned int data_size = 0; + unsigned short num_plugins = 0; /*-----------------------------------------------------*\ | Calculate data size | \*-----------------------------------------------------*/ - unsigned short num_plugins = (unsigned short)plugin_manager->GetPluginCount(); - data_size += sizeof(data_size); data_size += sizeof(num_plugins); if(plugin_manager) { + num_plugins = (unsigned short)plugin_manager->GetPluginCount(); + for(unsigned int i = 0; i < num_plugins; i++) { data_size += sizeof(unsigned short) * 3;