From 0b02dc6235a389c9dcec30be3611a2b7799e5455 Mon Sep 17 00:00:00 2001
From: Adam Honse <calcprogrammer1@gmail.com>
Date: Wed, 30 Sep 2026 11:49:47 -0500
Subject: [PATCH] Make device functions private in RGBController and fix
 DeviceUpdateLEDs usage in cli.cpp

---
 RGBController/RGBController.h | 34 +++++++++++++++++-----------------
 cli.cpp                       |  2 +-
 2 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/RGBController/RGBController.h b/RGBController/RGBController.h
index 79abf71c4..4f52a918e 100644
--- a/RGBController/RGBController.h
+++ b/RGBController/RGBController.h
@@ -196,23 +196,6 @@ public:
 
     void                    ConfigureDevice(controller_flags new_flags, std::string new_name);
 
-    /*-----------------------------------------------------*\
-    | Functions to be implemented in device implementation  |
-    \*-----------------------------------------------------*/
-    virtual void            DeviceConfigureDevice();
-    virtual void            DeviceConfigureZone(int zone_idx);
-
-    virtual void            DeviceUpdateLEDs();
-    virtual void            DeviceUpdateZoneLEDs(int zone);
-    virtual void            DeviceUpdateSingleLED(int led);
-
-    virtual void            DeviceUpdateMode();
-    virtual void            DeviceUpdateZoneMode(int zone);
-    virtual void            DeviceSaveMode();
-
-    virtual void            DeviceUpdateDeviceSpecificConfiguration();
-    virtual void            DeviceUpdateDeviceSpecificZoneConfiguration(int zone);
-
     /*-----------------------------------------------------*\
     | Static Serialized Description Functions               |
     \*-----------------------------------------------------*/
@@ -315,6 +298,23 @@ protected:
     void                    SetupColors();
     void                    UpdateLEDsInternal();
 
+    /*-----------------------------------------------------*\
+    | Functions to be implemented in device implementation  |
+    \*-----------------------------------------------------*/
+    virtual void            DeviceConfigureDevice();
+    virtual void            DeviceConfigureZone(int zone_idx);
+
+    virtual void            DeviceUpdateLEDs();
+    virtual void            DeviceUpdateZoneLEDs(int zone);
+    virtual void            DeviceUpdateSingleLED(int led);
+
+    virtual void            DeviceUpdateMode();
+    virtual void            DeviceUpdateZoneMode(int zone);
+    virtual void            DeviceSaveMode();
+
+    virtual void            DeviceUpdateDeviceSpecificConfiguration();
+    virtual void            DeviceUpdateDeviceSpecificZoneConfiguration(int zone);
+
 private:
     /*-----------------------------------------------------*\
     | Device thread variables                               |
diff --git a/cli.cpp b/cli.cpp
index 536753563..99b9eda42 100644
--- a/cli.cpp
+++ b/cli.cpp
@@ -1360,7 +1360,7 @@ void ApplyOptions(DeviceOptions& options, std::vector<RGBController *>& rgb_cont
     \*-----------------------------------------------------*/
     if(device->GetModeColorMode(mode) == MODE_COLORS_PER_LED)
     {
-        device->DeviceUpdateLEDs();
+        device->UpdateLEDs();
     }
 }