mirror/OpenRGB
1
0
Fork 0
mirror of https://github.com/CalcProgrammer1/OpenRGB.git synced 2026-03-10 01:58:09 -04:00
Code Issues Packages Projects Releases Wiki Activity

Revert data type to simple value for maximum compatibility

Browse Source 
- Keep data_type = 1 instead of 0x0B to maintain compatibility with existing devices
- While 0x0B is spec-compliant, many devices may work with the simpler value
- Keep other specification compliance fixes (sequence number, data size)
- Add both constants for future reference

This ensures existing WLED and other DDP devices continue working while
maintaining the benefits of other specification compliance improvements.
This commit is contained in:
Wolfieee Wolf
2025-07-01 17:23:21 +10:00
parent a00563f945
commit 1ec5cfe85f
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Controllers/DDPController/DDPController.cpp
View File

@@ -226,7 +226,7 @@ bool DDPController::SendDDPPacket(const DDPDevice& device, const unsigned char*
// CRITICAL FIX: Use 0x41 instead of 0x40 - WLED requires the Push bit to be set
header->flags = DDP_FLAG_VER_1 | DDP_FLAG_PUSH;
header->sequence = sequence_number & 0x0F; // Only use 4-bit nibble (0-15) per DDP spec
header->data_type = DDP_TYPE_RGB8; // RGB 8-bit per DDP spec
header->data_type = 1; // RGB data type (keeping simple value for compatibility)
header->dest_id = 1; // Default output device
header->data_offset = htonl(offset);
header->data_length = htons(length);