Move RGBController base destructor functionality into RGBController::Shutdown() so that update thread can be stopped before deleting the controller. Shutdown() must be called in every RGBController implementation before deleting the controller. Also some fixes to the NetworkServer to avoid deadlocking and disconnect issues

Controllers/QMKController/QMKOpenRGBController/QMKOpenRGBRev9Controller/RGBController_QMKOpenRGBRev9.cpp

@@ -257,6 +257,8 @@ RGBController_QMKOpenRGBRev9::RGBController_QMKOpenRGBRev9(QMKOpenRGBRev9Control
 
 RGBController_QMKOpenRGBRev9::~RGBController_QMKOpenRGBRev9()
 {
+    Shutdown();
+
     delete controller;
 }
 

Controllers/QMKController/QMKOpenRGBController/QMKOpenRGBRevBController/RGBController_QMKOpenRGBRevB.cpp

@@ -259,6 +259,8 @@ RGBController_QMKOpenRGBRevB::RGBController_QMKOpenRGBRevB(QMKOpenRGBRevBControl
 
 RGBController_QMKOpenRGBRevB::~RGBController_QMKOpenRGBRevB()
 {
+    Shutdown();
+
     delete controller;
 }
 

Controllers/QMKController/QMKOpenRGBController/QMKOpenRGBRevDController/RGBController_QMKOpenRGBRevD.cpp

@@ -258,6 +258,8 @@ RGBController_QMKOpenRGBRevD::RGBController_QMKOpenRGBRevD(QMKOpenRGBRevDControl
 
 RGBController_QMKOpenRGBRevD::~RGBController_QMKOpenRGBRevD()
 {
+    Shutdown();
+
     delete controller;
 }
 

Controllers/QMKController/QMKOpenRGBController/QMKOpenRGBRevEController/RGBController_QMKOpenRGBRevE.cpp

@@ -274,6 +274,8 @@ RGBController_QMKOpenRGBRevE::RGBController_QMKOpenRGBRevE(QMKOpenRGBRevDControl
 
 RGBController_QMKOpenRGBRevE::~RGBController_QMKOpenRGBRevE()
 {
+    Shutdown();
+
     delete controller;
 }
 

Controllers/QMKController/QMKVialRGBController/RGBController_QMKVialRGB.cpp

@@ -158,6 +158,8 @@ RGBController_QMKVialRGB::RGBController_QMKVialRGB(QMKVialRGBController* control
 
 RGBController_QMKVialRGB::~RGBController_QMKVialRGB()
 {
+    Shutdown();
+
     delete controller;
 }