From c7c92d0647e42bee14661c331d42d0b84b912107 Mon Sep 17 00:00:00 2001 From: Adam Honse Date: Tue, 14 Apr 2026 01:02:00 -0500 Subject: [PATCH] Close SDK connection if magic value is not correctly received --- NetworkClient.cpp | 4 +++- NetworkServer.cpp | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/NetworkClient.cpp b/NetworkClient.cpp index f9af6aff5..9953e5085 100644 --- a/NetworkClient.cpp +++ b/NetworkClient.cpp @@ -1014,6 +1014,7 @@ void NetworkClient::ListenThreadFunction() if(bytes_read <= 0) { + LOG_ERROR("[%s] recv_select failed receiving magic, closing listener", NETWORKCLIENT); goto listen_done; } @@ -1022,7 +1023,8 @@ void NetworkClient::ListenThreadFunction() \*---------------------------------------------------------*/ if(header.pkt_magic[i] != openrgb_sdk_magic[i]) { - continue; + LOG_ERROR("[%s] Invalid magic received, closing listener", NETWORKCLIENT); + goto listen_done; } } diff --git a/NetworkServer.cpp b/NetworkServer.cpp index 1cf6ea9c6..cde3a0474 100644 --- a/NetworkServer.cpp +++ b/NetworkServer.cpp @@ -1075,8 +1075,8 @@ void NetworkServer::ListenThreadFunction(NetworkClientInfo * client_info) \*---------------------------------------------*/ if(header.pkt_magic[i] != openrgb_sdk_magic[i]) { - LOG_ERROR("[%s] Invalid magic received", NETWORKSERVER); - continue; + LOG_ERROR("[%s] Invalid magic received, closing listener", NETWORKSERVER); + goto listen_done; } }