mirror/OpenRGB
1
0
Fork 0
mirror of https://github.com/CalcProgrammer1/OpenRGB.git synced 2026-05-18 19:46:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

Clean up some stuff in the Mountain keyboard controllers that violated conventions

Browse Source 
* Mountain60KeyboardController's detector was setting the name member directly, this is an outdated convention that breaks the RGBController rework, moved to a Controller member
    * Mountain60KeyboardController had some sort of HID redetect logic, this should not be part of the Controller, this will be handled in the future by HID hotplugging
    * Both MountainKeyboardControllers defined static variables to keep track of current mode, moved these to class members so that they won't conflict if two instances exist
    * Don't send any device updates as part of SetupZones
This commit is contained in:
Adam Honse
2026-01-11 03:08:04 -06:00
parent 416898b97b
commit f948d6e1d3
7 changed files with 59 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Controllers/MountainKeyboardController/MountainKeyboardControllerDetect.cpp
View File

@@ -44,9 +44,9 @@ void DetectMountain60KeyboardControllers(hid_device_info* info, const std::strin
if(dev)
{
Mountain60KeyboardController* controller = new Mountain60KeyboardController(dev, info->path);
Mountain60KeyboardController* controller = new Mountain60KeyboardController(dev, info->path, name);
RGBController_Mountain60Keyboard* rgb_controller = new RGBController_Mountain60Keyboard(controller);
rgb_controller->name = name;
ResourceManager::get()->RegisterRGBController(rgb_controller);
}
}