From f48a49ca030cb60b4633ebaa9db61ed3963afe01 Mon Sep 17 00:00:00 2001 From: "fossifybot[bot]" <212866877+fossifybot[bot]@users.noreply.github.com> Date: Mon, 1 Sep 2025 10:01:45 +0530 Subject: [PATCH] chore: update lint baselines (#551) Co-authored-by: fossifybot[bot] <212866877+fossifybot[bot]@users.noreply.github.com> --- app/detekt-baseline.xml | 10 -- app/lint-baseline.xml | 197 +++++++++++++++++++++------------------- 2 files changed, 104 insertions(+), 103 deletions(-) diff --git a/app/detekt-baseline.xml b/app/detekt-baseline.xml index 3866b61c..ce2aa9f5 100644 --- a/app/detekt-baseline.xml +++ b/app/detekt-baseline.xml @@ -5,7 +5,6 @@ ComplexCondition:Activity.kt$contact.rawId > 1000000 && contact.contactId > 1000000 && contact.rawId == contact.contactId && (isPackageInstalled(simpleContacts) || isPackageInstalled(simpleContactsDebug)) ComplexCondition:CallService.kt$CallService$!powerManager.isInteractive || call.isOutgoing() || isScreenLocked || config.alwaysShowFullscreen ComplexCondition:DialpadActivity.kt$DialpadActivity$(intent.action == Intent.ACTION_DIAL || intent.action == Intent.ACTION_VIEW) && intent.data != null && intent.dataString?.contains("tel:") == true - ComplexCondition:RecentsHelper.kt$RecentsHelper$callA.simID != callB.simID || (callA.name != callB.name && callA.name != callA.phoneNumber && callB.name != callB.phoneNumber) || callA.getDayCode() != callB.getDayCode() CyclomaticComplexMethod:CallActivity.kt$CallActivity$@SuppressLint("ClickableViewAccessibility") private fun handleSwipe() CyclomaticComplexMethod:CallManager.kt$CallManager.Companion$fun getPhoneState(): PhoneState CyclomaticComplexMethod:CallNotificationManager.kt$CallNotificationManager$@SuppressLint("NewApi") fun setupNotification(forceLowPriority: Boolean = false) @@ -21,7 +20,6 @@ EmptyFunctionBlock:MainActivity.kt$MainActivity.<no name provided>${} EmptyFunctionBlock:RecentCallsAdapter.kt$RecentCallsAdapter${} EmptyFunctionBlock:SpeedDialAdapter.kt$SpeedDialAdapter${} - ExplicitItLambdaParameter:FavoritesFragment.kt$FavoritesFragment${ it -> if (context.config.showCallConfirmation) { CallConfirmationDialog(activity as SimpleActivity, (it as Contact).getNameToDisplay()) { activity?.apply { initiateCall(it) { launchCallIntent(it) } } } } else { activity?.apply { initiateCall(it as Contact) { launchCallIntent(it) } } } } LargeClass:CallActivity.kt$CallActivity : SimpleActivity LongMethod:CallActivity.kt$CallActivity$@SuppressLint("ClickableViewAccessibility") private fun handleSwipe() LongMethod:RecentCallsAdapter.kt$RecentCallsAdapter.RecentCallViewHolder$fun bind(call: RecentCall) @@ -75,7 +73,6 @@ MaxLineLength:CallNotificationManager.kt$CallNotificationManager$setImageViewBitmap(R.id.notification_thumbnail, callContactAvatarHelper.getCircularBitmap(callContactAvatar)) MaxLineLength:CallNotificationManager.kt$CallNotificationManager$val importance = if (isHighPriority) NotificationManager.IMPORTANCE_HIGH else NotificationManager.IMPORTANCE_DEFAULT MaxLineLength:CallNotificationManager.kt$CallNotificationManager$val isHighPriority = context.powerManager.isInteractive && callState == Call.STATE_RINGING && !forceLowPriority - MaxLineLength:CallNotificationManager.kt$CallNotificationManager$val name = if (isHighPriority) "call_notification_channel_high_priority" else "call_notification_channel" MaxLineLength:CallNotificationManager.kt$CallNotificationManager$var callerName = if (callContact.name.isNotEmpty()) callContact.name else context.getString(R.string.unknown_caller) MaxLineLength:CallService.kt$CallService$// seems like startActivity can throw AndroidRuntimeException and ActivityNotFoundException, not yet sure when and why, lets show a notification MaxLineLength:ChangeSortingDialog.kt$ChangeSortingDialog$class @@ -118,7 +115,6 @@ MaxLineLength:RecentCallsAdapter.kt$RecentCallsAdapter$incomingMissedCallIcon = resources.getColoredDrawableWithColor(R.drawable.ic_call_missed_vector, missedCallColor) MaxLineLength:RecentCallsAdapter.kt$RecentCallsAdapter$private var phoneNumberOfflineGeocoderInstance: PhoneNumberOfflineGeocoder = PhoneNumberOfflineGeocoder.getInstance() MaxLineLength:RecentCallsAdapter.kt$RecentCallsAdapter$return (activity as MainActivity).cachedContacts.find { it.name == recentCall.name && it.doesHavePhoneNumber(recentCall.phoneNumber) } - MaxLineLength:RecentCallsAdapter.kt$RecentCallsAdapter.RecentCallDateViewHolder$else -> date.timestamp.formatDateOrTime(activity, hideTimeOnOtherDays = true, showCurrentYear = false) MaxLineLength:RecentCallsAdapter.kt$RecentCallsAdapter.RecentCallViewHolder$&& MaxLineLength:RecentCallsAdapter.kt$RecentCallsAdapter.RecentCallViewHolder$call.startTS.formatDateOrTime(context, hideTimeOnOtherDays = false, showCurrentYear = false, hideTodaysDate = false) MaxLineLength:RecentCallsAdapter.kt$RecentCallsAdapter.RecentCallViewHolder$nameToShow = SpannableString(nameToShow.toString().highlightTextPart(textToHighlight, properPrimaryColor)) @@ -181,12 +177,8 @@ WildcardImport:ContactsAdapter.kt$import android.view.* WildcardImport:ContactsAdapter.kt$import org.fossify.commons.extensions.* WildcardImport:ContactsAdapter.kt$import org.fossify.commons.helpers.* - WildcardImport:ContactsFragment.kt$import org.fossify.commons.extensions.* - WildcardImport:ContactsFragment.kt$import org.fossify.commons.helpers.* WildcardImport:DialerActivity.kt$import org.fossify.commons.extensions.* WildcardImport:ExportCallHistoryDialog.kt$import org.fossify.commons.extensions.* - WildcardImport:FavoritesFragment.kt$import org.fossify.commons.extensions.* - WildcardImport:FavoritesFragment.kt$import org.fossify.commons.helpers.* WildcardImport:FilterContactSourcesDialog.kt$import org.fossify.commons.extensions.* WildcardImport:MainActivity.kt$import org.fossify.commons.extensions.* WildcardImport:MainActivity.kt$import org.fossify.commons.helpers.* @@ -199,7 +191,5 @@ WildcardImport:RecentsHelper.kt$import org.fossify.commons.extensions.* WildcardImport:RecentsHelper.kt$import org.fossify.commons.helpers.* WildcardImport:SelectContactDialog.kt$import org.fossify.commons.extensions.* - WildcardImport:SettingsActivity.kt$import org.fossify.commons.extensions.* - WildcardImport:SettingsActivity.kt$import org.fossify.commons.helpers.* diff --git a/app/lint-baseline.xml b/app/lint-baseline.xml index 6068f360..67633157 100644 --- a/app/lint-baseline.xml +++ b/app/lint-baseline.xml @@ -8,7 +8,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -41,7 +41,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -91,7 +91,7 @@ - - - - + + + + + + + + @@ -937,7 +948,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -948,7 +959,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> @@ -959,7 +970,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -970,7 +981,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -981,7 +992,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -992,7 +1003,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -1003,7 +1014,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -1014,7 +1025,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -1025,7 +1036,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> @@ -1036,7 +1047,18 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> + + + + @@ -1047,7 +1069,7 @@ errorLine2=" ~~~~~~~~~~~~~~~~~~"> @@ -1056,39 +1078,6 @@ message=""faq_1_text" is not translated in "fil" (Filipino; Pilipino), "lt" (Lithuanian), "lv" (Latvian), "ia" (Interlingua), "mk" (Macedonian), "ms" (Malay), "en" (English), "is" (Icelandic), "my" (Burmese), "nb" (Norwegian Bokmål), "ne" (Nepali), "az" (Azerbaijani), "nn" (Norwegian Nynorsk), "be" (Belarusian), "bn" (Bangla), "br" (Breton), "bs" (Bosnian), "oc" (Occitan (post 1500)), "si" (Sinhala), "zgh" (Standard Moroccan Tamazight), "ltg", "kn" (Kannada), "or" (Odia), "kr" (Kanuri), "sat" (Santali), "cr" (Cree), "pa" (Punjabi), "te" (Telugu), "th" (Thai), "cy" (Welsh), "ckb"" errorLine1=" <string name="faq_1_text">Such issues can have many device and system specific reasons, hard to say in general. You should look around in your device settings and make sure that the app is allowed to pop up when in background and allow displaying over other apps.</string>" errorLine2=" ~~~~~~~~~~~~~~~~~"> - - - - - - - - - - - - + + + + + + + + + + + + @@ -1183,17 +1205,6 @@ column="5"/> - - - -