Trial97
6699d3eca0
clang-tidy: clang-analyzer-*
...
This commit aims to fix all clang-analyzer-* warnings from clang-tidy.
Here is the list of the ones found in project:
"clang-analyzer-core.uninitialized.UndefReturn",
"clang-analyzer-deadcode.DeadStores",
"clang-analyzer-optin.core.EnumCastOutOfRange",
Some exceptions:
clang-analyzer-cplusplus.NewDeleteLeaks -> may need to disable it as
is a false positive
clang-analyzer-optin.cplusplus.VirtualCall -> may need to disable it
(or refactor a bunch of code to drop the virtual from those functions)
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2026-05-13 10:20:26 +03:00
Octol1ttle
838687fb2e
fix: log error if file open/commit fails
...
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com >
2026-03-23 01:07:05 +05:00
Octol1ttle
e27246c3f9
fix: add missing returns after emitSucceeded
...
Signed-off-by: Octol1ttle <l1ttleofficial@outlook.com >
2026-01-21 18:30:31 +05:00
Seth Flynn
fd91f87c21
style: re-format tree with editorconfig
...
```
find $PWD \
-type f \
! -path '*/.git/*' ! -path '*/flatpak/shared-modules/*' \
! -path '*/libraries/*' ! -path '*/testdata/*' ! -name '*.patch' \
! -name '*.svg' ! -name '*.scd' ! -path '*/program_info/LICENSE' \
! -path '*/COPYING.md' ! -path '*/cmake/*' ! -name '.gitmodules' \
-exec eclint -fix {} \;
```
Signed-off-by: Seth Flynn <getchoo@tuta.io >
2026-01-18 15:48:07 -05:00
Dylan Schooner
8d42bdaf6b
Check return value of 'virtual bool QFile::open(QIODeviceBase::OpenMode)'
...
Signed-off-by: Dylan Schooner <dschooner05@gmail.com >
2025-10-30 03:15:14 -04:00
Trial97
29cff14fd6
removed some duplicate code
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2025-09-15 18:25:07 +03:00
TheKodeToad
29d73a474f
Reduce usage of [[nodiscard]] attributes
...
Signed-off-by: TheKodeToad <TheKodeToad@proton.me >
2025-07-07 20:56:29 +01:00
hanlie
6bda537633
Improvements to modlist export
...
Added .replace("{mod_id}", modID)
Signed-off-by: hanlie <48323966+HanlieChina@users.noreply.github.com >
2025-03-19 12:35:22 +08:00
timoreo
b2a37452be
Merge pull request #3024 from Trial97/leak
...
fix leak on resource search
2024-11-15 06:18:33 +01:00
Trial97
0e80aae1b8
Merge branch 'develop' of https://github.com/PrismLauncher/PrismLauncher into lambda
2024-10-30 19:35:25 +02:00
Trial97
82bffabb69
do not capture by default all values in lambdas
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2024-10-30 18:16:43 +02:00
Trial97
8e7d84d05b
fix leak on resource search
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2024-10-29 00:40:13 +02:00
TheKodeToad
2b22a1aebe
Reimplement View Homepage
...
I removed it for some reason, but now it's back for all pages!
Signed-off-by: TheKodeToad <TheKodeToad@proton.me >
2024-10-28 20:14:56 +00:00
TheKodeToad
6a6fe60a5b
Revert "Use non-mod metadata in ModrinthPackExportTask"
...
Out-of-scope
Signed-off-by: TheKodeToad <TheKodeToad@proton.me >
2024-10-28 10:29:49 +00:00
TheKodeToad
13e13ea8fc
Use non-mod metadata in ModrinthPackExportTask
...
Signed-off-by: TheKodeToad <TheKodeToad@proton.me >
2024-10-25 19:13:41 +01:00
Trial97
5d8d1c4b90
transform hashFile to lambda
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2024-07-04 16:47:27 +03:00
Trial97
1dd21a5e4a
fix crash with hash task
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2024-07-04 16:38:40 +03:00
Trial97
888b22b4c7
rename variable
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2024-06-18 22:36:39 +03:00
Trial97
ac8c7baff2
fix tipo
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2024-06-18 17:49:07 +03:00
Trial97
9cbdbddb08
made hasing task async
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2024-06-18 17:27:17 +03:00
Trial97
766ddc80e3
refactored hassing task
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2024-06-18 16:51:26 +03:00
Trial97
45463dcd75
Merge branch 'develop' of https://github.com/PrismLauncher/PrismLauncher into import_zip
2024-06-04 11:04:02 +03:00
Alexandru Ionut Tripon
2145f9f0ac
Merge pull request #1847 from Trial97/move_export2
...
Improvements to modlist export
2024-05-31 09:58:32 +03:00
Trial97
ba947993c2
Merge branch 'develop' of https://github.com/PrismLauncher/PrismLauncher into import_zip
2024-05-18 12:47:01 +03:00
Trial97
3336f8107c
Removed AuthRequest and NetAction
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2024-05-14 00:21:45 +03:00
Trial97
3a4f82ffd1
Merge branch 'develop' of https://github.com/PrismLauncher/PrismLauncher into import_zip
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2024-04-24 00:21:39 +03:00
Trial97
d88fb266a5
Merge branch 'develop' of https://github.com/PrismLauncher/PrismLauncher into move_export2
2024-04-20 17:42:58 +03:00
TheKodeToad
ded77e6183
Fix NetJob use-after-free
...
Signed-off-by: TheKodeToad <TheKodeToad@proton.me >
2024-02-11 15:43:36 +00:00
Trial97
031a9f4738
Replaced QFile::remove with FS::deletePath
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2024-02-10 11:03:51 +02:00
Trial97
4498d32cc0
Merge branch 'develop' of https://github.com/PrismLauncher/PrismLauncher into move_export2
2023-12-13 14:37:02 +02:00
Trial97
657416fe30
Removed header
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-12-03 21:29:02 +02:00
Trial97
bedb4da869
Added filename to the modlist export
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-11-14 19:37:23 +02:00
Trial97
abbac5c26c
Merge branch 'develop' of https://github.com/PrismLauncher/PrismLauncher into fail_concurrent_task
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-09-01 22:28:59 +03:00
TheKodeToad
25ce11d85d
Merge pull request #1539 from Trial97/refactor_modpack_ux
...
Improvements to modpack UX
2023-08-31 14:58:54 +01:00
Trial97
aa065f2b51
Updated dependency resolution
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-08-23 13:28:23 +03:00
Trial97
44ff247f5f
feat:refactored modpack ux
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-08-18 20:03:02 +03:00
Trial97
42a6c670c7
Merge branch 'develop' of https://github.com/PrismLauncher/PrismLauncher into fail_concurrent_task
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-08-15 12:52:59 +03:00
Sefa Eyeoglu
91ba4cf75e
chore: reformat
...
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net >
2023-08-14 18:16:53 +02:00
Sefa Eyeoglu
ef6f9487f4
Merge remote-tracking branch 'upstream/staging' into chore/add-compiler-warnings
2023-08-10 20:38:32 +02:00
Trial97
5981e7815a
Merge branch 'develop' of https://github.com/PrismLauncher/PrismLauncher into fail_concurrent_task
2023-08-05 19:06:01 +03:00
Rachel Powers
2d1197f59f
Merge branch 'develop' into refactor/net-split-headers-to-proxy-class
...
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
2023-07-31 22:26:20 -07:00
Rachel Powers
b9fe37aec1
Merge branch 'develop' into chore/add-compiler-warnings
...
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
2023-07-30 15:33:46 -07:00
Trial97
6cf7c0a647
Connected last fail signals
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-07-15 20:17:16 +03:00
Trial97
1ccfba13eb
renames
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-07-14 23:41:51 +03:00
Trial97
1495bfb73e
Made custom template enabled all time
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-07-14 23:41:37 +03:00
Trial97
9b02c31f8d
escaped text for html export
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-07-14 23:35:18 +03:00
Trial97
50dae9d4f3
Moved to separate functions
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-07-14 23:34:28 +03:00
Trial97
9a3931dac6
Added json and csv format
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-07-14 23:34:21 +03:00
Trial97
515197fba2
fix: html sintax for modlist export
...
Signed-off-by: Trial97 <alexandru.tripon97@gmail.com >
2023-07-14 23:34:03 +03:00
Rachel Powers
8d7dcdfc5b
chore: fix shadowed member and signed/unsigned mismatch
...
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
chore: supress unused with [[maybe_unused]]
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
chore: unshadow ^&^& static_cast implicit return
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
chore: deshadow and mark unused in parse task
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
chore: mark unused in folder models
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
chore: deshadow and mark unused with instances
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
chore: more deshadow and unused
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
chore: remove uneeded simicolons
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
chore: mark unused
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
chore: prevent shadow
Signed-off-by: Rachel Powers <508861+Ryex@users.noreply.github.com >
2023-07-01 23:39:38 -07:00