Files
WoWee/include/game
Kelsi 5b7472d974 docs(comments): correct WotLK opcode and update-field indices in comments
- src/game/game_handler.cpp:1589: SMSG_ACHIEVEMENT_EARNED is 0x468 on
  WotLK 3.3.5a per Data/expansions/wotlk/opcodes.json; the comment
  said 0x4AB, which is actually SMSG_CLIENTCACHE_VERSION.
- include/game/protocol_constants.hpp:18: header declares this file
  is WotLK-only, but the comment claimed UNIT_FIELD_FLAGS lives at
  index 46 (Classic/TBC/Turtle value). WotLK 3.3.5a is 59
  (Data/expansions/wotlk/update_fields.json:44, MEMORY.md). Comment
  rewritten to give both indices and note the bitmask is stable.
- include/game/protocol_constants.hpp:23: same problem for
  UNIT_NPC_FLAGS — comment said offset 147 (Classic/Turtle), real
  WotLK index is 82. Comment fixed the same way.

No code change — these were comment-only and the runtime indices are
read from the update-field tables, not these comments. But the file
is supposed to be the canonical reference for WotLK constants, so
the comments materially mislead readers.
2026-05-15 00:06:57 -07:00
..