From 08c85a8a644142006c5a339f12ded684bd9fa859 Mon Sep 17 00:00:00 2001 From: john liddell Date: Sat, 7 Nov 2020 12:39:07 -0600 Subject: [PATCH] Use openPath instead of openExternal Fix #365 --- .../src/app/pages/my-addons/my-addons.component.ts | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/wowup-electron/src/app/pages/my-addons/my-addons.component.ts b/wowup-electron/src/app/pages/my-addons/my-addons.component.ts index fdb3d35f..a1ff2b3f 100644 --- a/wowup-electron/src/app/pages/my-addons/my-addons.component.ts +++ b/wowup-electron/src/app/pages/my-addons/my-addons.component.ts @@ -173,7 +173,7 @@ export class MyAddonsComponent implements OnInit, OnDestroy { public ngOnInit(): void { const sortOrder = this.wowUpService.myAddonsSortOrder; - if(sortOrder){ + if (sortOrder) { this.activeSort = sortOrder.name; this.activeSortDirection = sortOrder.direction; } @@ -361,13 +361,7 @@ export class MyAddonsComponent implements OnInit, OnDestroy { public onShowfolder(addon: Addon) { try { const addonPath = this.addonService.getFullInstallPath(addon); - this.electronService.shell.openExternal( - addonPath, - //open issue on Electron causing activate false to set to foreground instead of background - //https://github.com/electron/electron/issues/12492 - //temporary workaround until its fixed in Electron - { activate: this.electronService.isMac } - ); + this.electronService.shell.openPath(addonPath); } catch (err) { console.error(err); } @@ -460,7 +454,7 @@ export class MyAddonsComponent implements OnInit, OnDestroy { }); } - public onInstall() {} + public onInstall() { } public onClickIgnoreAddon(evt: MatCheckboxChange, listItem: AddonViewModel) { this.onClickIgnoreAddons(evt, [listItem]);