From bab490de814ba844c0bd13fb410a06ae82ccfa45 Mon Sep 17 00:00:00 2001 From: Lynn Date: Sun, 8 Nov 2020 10:52:21 +0100 Subject: [PATCH] Fixed a null pointer when no release is found via "Install from URL" --- .../src/app/addon-providers/github-addon-provider.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/wowup-electron/src/app/addon-providers/github-addon-provider.ts b/wowup-electron/src/app/addon-providers/github-addon-provider.ts index f7864dcd..26d71d76 100644 --- a/wowup-electron/src/app/addon-providers/github-addon-provider.ts +++ b/wowup-electron/src/app/addon-providers/github-addon-provider.ts @@ -57,10 +57,13 @@ export class GitHubAddonProvider implements AddonProvider { const results = await this.getReleases(repoPath).toPromise(); const latestRelease = this.getLatestRelease(results); - const asset = this.getValidAsset(latestRelease, clientType); + if (!latestRelease) { + throw new Error(`No release found in ${addonUri}`); + } + const asset = this.getValidAsset(latestRelease, clientType); if (asset == null) { - throw new Error(`No release found: ${addonUri}`); + throw new Error(`No release assets found in ${addonUri}`); } var repository = await this.getRepository(repoPath).toPromise();