From 976ac5e1d4dfce6fa09b3b8a79be8577ea2085f4 Mon Sep 17 00:00:00 2001 From: jliddev Date: Fri, 11 Jun 2021 09:12:53 -0500 Subject: [PATCH] Fix PR notes --- wowup-electron/app/main.ts | 3 ++- wowup-electron/e2e/tsconfig.e2e.json | 9 ------- .../addon-detail/addon-detail.component.ts | 24 ------------------- .../components/footer/footer.component.html | 17 ------------- 4 files changed, 2 insertions(+), 51 deletions(-) diff --git a/wowup-electron/app/main.ts b/wowup-electron/app/main.ts index 0f45b190..3fd45101 100644 --- a/wowup-electron/app/main.ts +++ b/wowup-electron/app/main.ts @@ -321,7 +321,8 @@ function createWindow(): BrowserWindow { }); win.once("show", () => { - win.webContents.openDevTools(); + // win.webContents.openDevTools(); + if (mainWindowManager.isFullScreen) { win.setFullScreen(true); } else if (mainWindowManager.isMaximized) { diff --git a/wowup-electron/e2e/tsconfig.e2e.json b/wowup-electron/e2e/tsconfig.e2e.json index 3673cc02..5596dea2 100644 --- a/wowup-electron/e2e/tsconfig.e2e.json +++ b/wowup-electron/e2e/tsconfig.e2e.json @@ -12,12 +12,3 @@ "**.ts" ] } -// { -// "extends": "../tsconfig.base.json", -// "compilerOptions": { -// "outDir": "../out-tsc/e2e", -// "module": "commonjs", -// "types": ["mocha", "node"] -// }, -// "include": ["**.ts"] -// } diff --git a/wowup-electron/src/app/components/addon-detail/addon-detail.component.ts b/wowup-electron/src/app/components/addon-detail/addon-detail.component.ts index 96a3027d..f3de9919 100644 --- a/wowup-electron/src/app/components/addon-detail/addon-detail.component.ts +++ b/wowup-electron/src/app/components/addon-detail/addon-detail.component.ts @@ -303,30 +303,6 @@ export class AddonDetailComponent implements OnInit, OnDestroy, AfterViewChecked }; private onOpenLink = (element: HTMLAnchorElement): boolean => { - // e.preventDefault(); - - // // Go up the call chain to find the tag - // const path = (e as any).path as HTMLElement[]; - // let anchor: HTMLAnchorElement | undefined = undefined; - // for (const element of path) { - // if (element.tagName !== "A") { - // continue; - // } - - // anchor = element as HTMLAnchorElement; - // break; - // } - - // if (!anchor) { - // console.warn("No anchor in path"); - // return false; - // } - - // if (anchor.href.toLowerCase().indexOf("http") !== 0 || anchor.href.toLowerCase().indexOf("localhost") !== -1) { - // console.warn(`Unhandled relative path: ${anchor.href}`); - // return false; - // } - this.confirmLinkNavigation(element.href); return false; diff --git a/wowup-electron/src/app/components/footer/footer.component.html b/wowup-electron/src/app/components/footer/footer.component.html index 52e6b1e9..64a8f2a8 100644 --- a/wowup-electron/src/app/components/footer/footer.component.html +++ b/wowup-electron/src/app/components/footer/footer.component.html @@ -1,21 +1,4 @@