From d2ec9ec9f2bb744407307237fa43f6987da4a139 Mon Sep 17 00:00:00 2001 From: jliddev Date: Thu, 3 Sep 2020 23:21:30 -0500 Subject: [PATCH] Dispose thumbnail streams --- WowUp.WPF/Converters/UriToThumbnailConverter.cs | 11 ++++++++++- .../Properties/PublishProfiles/FolderProfile.pubxml | 2 +- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/WowUp.WPF/Converters/UriToThumbnailConverter.cs b/WowUp.WPF/Converters/UriToThumbnailConverter.cs index 4717aa24..4f297982 100644 --- a/WowUp.WPF/Converters/UriToThumbnailConverter.cs +++ b/WowUp.WPF/Converters/UriToThumbnailConverter.cs @@ -1,6 +1,7 @@ using Serilog; using System; using System.Globalization; +using System.IO; using System.Windows.Data; using System.Windows.Media.Imaging; using WowUp.WPF.Utilities; @@ -23,6 +24,8 @@ namespace WowUp.WPF.Converters if (value is Uri uri) { + MemoryStream imageStream = null; + try { BitmapImage thumbnail = new BitmapImage(); @@ -31,7 +34,8 @@ namespace WowUp.WPF.Converters if (uri.IsFile) { - thumbnail.StreamSource = FileUtilities.GetMemoryStreamFromFile(uri.LocalPath); + imageStream = FileUtilities.GetMemoryStreamFromFile(uri.LocalPath); + thumbnail.StreamSource = imageStream; } else { @@ -46,6 +50,11 @@ namespace WowUp.WPF.Converters { Log.Error(ex, "Failed to create bitmap image"); } + finally + { + imageStream?.Close(); + imageStream?.Dispose(); + } } return null; diff --git a/WowUp.WPF/Properties/PublishProfiles/FolderProfile.pubxml b/WowUp.WPF/Properties/PublishProfiles/FolderProfile.pubxml index 9817a895..8975df70 100644 --- a/WowUp.WPF/Properties/PublishProfiles/FolderProfile.pubxml +++ b/WowUp.WPF/Properties/PublishProfiles/FolderProfile.pubxml @@ -12,7 +12,7 @@ https://go.microsoft.com/fwlink/?LinkID=208121. win-x64 true True - True + False True \ No newline at end of file