diff --git a/wowup-electron/package.json b/wowup-electron/package.json index 521e9a77..97bddc8a 100644 --- a/wowup-electron/package.json +++ b/wowup-electron/package.json @@ -1,7 +1,7 @@ { "name": "wowup", "productName": "WowUp", - "version": "2.3.0-beta.5", + "version": "2.3.0-beta.6", "description": "World of Warcraft addon updater", "homepage": "https://wowup.io", "author": { diff --git a/wowup-electron/src/app/addon-providers/addon-provider.ts b/wowup-electron/src/app/addon-providers/addon-provider.ts index 5632517a..d0c9f5d0 100644 --- a/wowup-electron/src/app/addon-providers/addon-provider.ts +++ b/wowup-electron/src/app/addon-providers/addon-provider.ts @@ -63,15 +63,6 @@ export abstract class AddonProvider { return Promise.resolve([]); } - public searchByName( - addonName: string, - folderName: string, - installation: WowInstallation, - nameOverride?: string - ): Promise { - return Promise.resolve([]); - } - public getById(addonId: string, installation: WowInstallation): Observable { return of(undefined); } diff --git a/wowup-electron/src/app/app.component.ts b/wowup-electron/src/app/app.component.ts index 92793c99..6c2cc2d5 100644 --- a/wowup-electron/src/app/app.component.ts +++ b/wowup-electron/src/app/app.component.ts @@ -355,12 +355,14 @@ export class AppComponent implements OnInit, OnDestroy, AfterViewInit { reset, }); } else if ( - error.innerError instanceof GitHubFetchRepositoryError || - error.innerError instanceof GitHubFetchReleasesError + error.innerError instanceof GitHubFetchReleasesError || + error.innerError instanceof GitHubFetchRepositoryError ) { errorMessage = this.translate.instant("COMMON.ERRORS.GITHUB_REPOSITORY_FETCH_ERROR", { addonName: error.addonName, }); + } else if (error instanceof AddonSyncError) { + return; } this._snackbarService.showErrorSnackbar(errorMessage); diff --git a/wowup-electron/src/app/services/warcraft/warcraft-installation.service.ts b/wowup-electron/src/app/services/warcraft/warcraft-installation.service.ts index ec14ec3f..4376726c 100644 --- a/wowup-electron/src/app/services/warcraft/warcraft-installation.service.ts +++ b/wowup-electron/src/app/services/warcraft/warcraft-installation.service.ts @@ -167,8 +167,7 @@ export class WarcraftInstallationService { } public async createWowInstallationForPath(applicationPath: string): Promise { - const binaryName = path.basename(applicationPath); - const clientType = this._warcraftService.getClientTypeForBinary(binaryName); + const clientType = this._warcraftService.getClientTypeForBinary(applicationPath); const typeName = getEnumName(WowClientType, clientType); const currentInstallations = this.getWowInstallationsByClientType(clientType);