From a5c8ff91b5d80930e01daad70f6f61a9503a8cb1 Mon Sep 17 00:00:00 2001 From: Leendert de Borst Date: Fri, 24 Oct 2025 17:05:05 +0200 Subject: [PATCH] Cleanup (#520) --- .../java/net/aliasvault/app/autofill/AutofillService.kt | 8 -------- .../AliasVaultCredentialProviderService.kt | 1 - .../app/credentialprovider/CredentialIdentityStore.kt | 3 --- .../app/credentialprovider/PasskeyRegistrationActivity.kt | 3 --- .../app/nativevaultmanager/NativeVaultManager.kt | 4 ---- .../keystoreprovider/AndroidKeystoreProvider.kt | 1 - .../main/java/net/aliasvault/app/webapi/WebApiService.kt | 5 ----- 7 files changed, 25 deletions(-) diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/autofill/AutofillService.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/autofill/AutofillService.kt index ff95bba35..8a8de4b85 100644 --- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/autofill/AutofillService.kt +++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/autofill/AutofillService.kt @@ -60,8 +60,6 @@ class AutofillService : AutofillService() { } try { - Log.d(TAG, "onFillRequest called") - // Check if request was cancelled if (cancellationSignal.isCanceled) { return @@ -123,15 +121,11 @@ class AutofillService : AutofillService() { } private fun launchActivityForAutofill(fieldFinder: FieldFinder, callback: (FillResponse?) -> Unit) { - Log.d(TAG, "Launching activity for autofill authentication") - // Get the app/website information from assist structure. val appInfo = fieldFinder.getAppInfo() - Log.d(TAG, "Autofill request from: $appInfo") // Ignore requests from our own unlock page as this would cause a loop if (appInfo == "net.aliasvault.app") { - Log.d(TAG, "Skipping autofill request from AliasVault app itself") callback(null) return } @@ -144,7 +138,6 @@ class AutofillService : AutofillService() { if (store.tryGetAllCredentials(object : CredentialOperationCallback { override fun onSuccess(result: List) { try { - Log.d(TAG, "Retrieved ${result.size} credentials") if (result.isEmpty()) { // No credentials available Log.d(TAG, "No credentials available") @@ -217,7 +210,6 @@ class AutofillService : AutofillService() { }) ) { // Successfully used cached key - method returns true - Log.d(TAG, "Successfully retrieved credentials with unlocked vault") return } } diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/AliasVaultCredentialProviderService.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/AliasVaultCredentialProviderService.kt index d9f12cc18..aadd527db 100644 --- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/AliasVaultCredentialProviderService.kt +++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/AliasVaultCredentialProviderService.kt @@ -190,7 +190,6 @@ class AliasVaultCredentialProviderService : CredentialProviderService() { ): BeginCreateCredentialResponse? { // Get or initialize VaultStore instance (needed for subsequent passkey registration) VaultStore.getExistingInstance() ?: run { - Log.d(TAG, "VaultStore not initialized, initializing now...") // Need a FragmentActivity reference for biometrics, but this is a service // We'll create a minimal VaultStore instance here val keystoreProvider = AndroidKeystoreProvider(applicationContext) { null } diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/CredentialIdentityStore.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/CredentialIdentityStore.kt index 12b064bc7..2900ba59f 100644 --- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/CredentialIdentityStore.kt +++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/CredentialIdentityStore.kt @@ -114,8 +114,6 @@ class CredentialIdentityStore private constructor(context: Context) { prefs.edit() .putString(KEY_PASSKEY_IDENTITIES, jsonArray.toString()) .apply() - - Log.d(TAG, "Saved ${passkeyIdentities.size} passkey identities") } catch (e: Exception) { Log.e(TAG, "Error saving credential identities", e) } @@ -163,7 +161,6 @@ class CredentialIdentityStore private constructor(context: Context) { prefs.edit() .remove(KEY_PASSKEY_IDENTITIES) .apply() - Log.d(TAG, "Removed all credential identities") } /** diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/PasskeyRegistrationActivity.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/PasskeyRegistrationActivity.kt index 665f08786..b4744f00e 100644 --- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/PasskeyRegistrationActivity.kt +++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/credentialprovider/PasskeyRegistrationActivity.kt @@ -42,7 +42,6 @@ class PasskeyRegistrationActivity : FragmentActivity() { try { // Get or initialize VaultStore instance vaultStore = VaultStore.getExistingInstance() ?: run { - Log.d(TAG, "VaultStore not initialized, initializing now...") val keystoreProvider = AndroidKeystoreProvider(applicationContext) { this } val storageProvider = AndroidStorageProvider(applicationContext) VaultStore.getInstance(keystoreProvider, storageProvider) @@ -129,7 +128,6 @@ class PasskeyRegistrationActivity : FragmentActivity() { } }, ) - Log.d(TAG, "Waiting for biometric authentication...") } catch (e: Exception) { Log.e(TAG, "Error in onCreate", e) finish() @@ -143,7 +141,6 @@ class PasskeyRegistrationActivity : FragmentActivity() { try { // Check for existing passkeys val db = vaultStore.database - Log.d(TAG, "Db is not null?: ${db != null}") if (db != null) { viewModel.existingPasskeys = vaultStore.getPasskeysWithCredentialInfo( diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/nativevaultmanager/NativeVaultManager.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/nativevaultmanager/NativeVaultManager.kt index d9c530f7c..0198aa1b4 100644 --- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/nativevaultmanager/NativeVaultManager.kt +++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/nativevaultmanager/NativeVaultManager.kt @@ -611,8 +611,6 @@ class NativeVaultManager(reactContext: ReactApplicationContext) : @ReactMethod override fun copyToClipboardWithExpiration(text: String, expirationSeconds: Double, promise: Promise?) { try { - Log.d(TAG, "Copying to clipboard with expiration of $expirationSeconds seconds") - val clipboardManager = reactApplicationContext.getSystemService( android.content.Context.CLIPBOARD_SERVICE, ) as android.content.ClipboardManager @@ -689,7 +687,6 @@ class NativeVaultManager(reactContext: ReactApplicationContext) : val alarmManager = reactApplicationContext.getSystemService(android.content.Context.ALARM_SERVICE) as android.app.AlarmManager if (!alarmManager.canScheduleExactAlarms()) { - Log.d(TAG, "Requesting exact alarm permission via system settings") val intent = Intent().apply { action = Settings.ACTION_REQUEST_SCHEDULE_EXACT_ALARM data = Uri.parse("package:${reactApplicationContext.packageName}") @@ -724,7 +721,6 @@ class NativeVaultManager(reactContext: ReactApplicationContext) : } else { true // Pre-Android 6.0 doesn't have battery optimization } - Log.d(TAG, "Is ignoring battery optimizations: $isIgnoring") promise?.resolve(isIgnoring) } catch (e: Exception) { Log.e(TAG, "Error checking battery optimization status", e) diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/keystoreprovider/AndroidKeystoreProvider.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/keystoreprovider/AndroidKeystoreProvider.kt index ef73264b3..932f8be17 100644 --- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/keystoreprovider/AndroidKeystoreProvider.kt +++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/vaultstore/keystoreprovider/AndroidKeystoreProvider.kt @@ -162,7 +162,6 @@ class AndroidKeystoreProvider( val keyFile = File(context.filesDir, ENCRYPTED_KEY_FILE) keyFile.writeText(encryptedKeyB64) - Log.d(TAG, "Encryption key stored successfully") callback.onSuccess("Key stored successfully") } catch (e: Exception) { Log.e(TAG, "Error storing encryption key", e) diff --git a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/webapi/WebApiService.kt b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/webapi/WebApiService.kt index dbc7abf56..bd69fa9f3 100644 --- a/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/webapi/WebApiService.kt +++ b/apps/mobile-app/android/app/src/main/java/net/aliasvault/app/webapi/WebApiService.kt @@ -119,10 +119,7 @@ class WebApiService(private val context: Context) { if (requiresAuth && !requestHeaders.containsKey("Authorization")) { getAccessToken()?.let { accessToken -> requestHeaders["Authorization"] = "Bearer $accessToken" - Log.d(TAG, "Added Authorization header from stored token") } - } else if (requiresAuth && requestHeaders.containsKey("Authorization")) { - Log.d(TAG, "Using provided Authorization header instead of stored token") } // Add client version header @@ -318,8 +315,6 @@ class WebApiService(private val context: Context) { */ suspend fun extractFavicon(url: String): ByteArray? = withContext(Dispatchers.IO) { try { - Log.d(TAG, "Extracting favicon for $url") - val response = executeRequest( method = "GET", endpoint = "Favicon/Extract?url=$url",