From c8fa9255cfcd075948ddca772714af8cfb47d55c Mon Sep 17 00:00:00 2001
From: Leendert de Borst <ldeborst@xivisoft.com>
Date: Tue, 9 Dec 2025 22:21:29 +0100
Subject: [PATCH] Update tests (#1404)

---
 .../entrypoints/popup/pages/items/ItemsList.tsx    |  6 +++---
 apps/browser-extension/src/i18n/locales/en.json    |  2 ++
 .../tests/e2e/05-vault-merge.spec.ts               | 14 ++------------
 .../browser-extension/tests/fixtures/TestClient.ts |  4 ++--
 4 files changed, 9 insertions(+), 17 deletions(-)

diff --git a/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx b/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx
index 9d71c7de7..e00a9122d 100644
--- a/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx
+++ b/apps/browser-extension/src/entrypoints/popup/pages/items/ItemsList.tsx
@@ -102,10 +102,10 @@ const ItemsList: React.FC = () => {
 
   /**
    * Handle add new item.
-   * Navigate to item type selector for new item-based flow.
+   * Navigate directly to add item page (defaults to Login type).
    */
   const handleAddItem = useCallback(() : void => {
-    navigate('/items/select-type');
+    navigate('/items/add');
   }, [navigate]);
 
   /**
@@ -579,7 +579,7 @@ const ItemsList: React.FC = () => {
 
           {/* Items */}
           {filteredItems.length > 0 && (
-            <ul className="space-y-2">
+            <ul id="items-list" className="space-y-2">
               {filteredItems.map(item => (
                 <ItemCard
                   key={item.Id}
diff --git a/apps/browser-extension/src/i18n/locales/en.json b/apps/browser-extension/src/i18n/locales/en.json
index d14a22e3c..d6bbb26c1 100644
--- a/apps/browser-extension/src/i18n/locales/en.json
+++ b/apps/browser-extension/src/i18n/locales/en.json
@@ -290,6 +290,8 @@
     "selectType": "Add New Item",
     "selectTypeDescription": "Choose the type of item you want to create",
     "typeLabel": "Item Type",
+    "creating": "Creating",
+    "generateAlias": "Generate random alias",
     "login": {
       "title": "Login",
       "description": "Username, password, and website credentials"
diff --git a/apps/browser-extension/tests/e2e/05-vault-merge.spec.ts b/apps/browser-extension/tests/e2e/05-vault-merge.spec.ts
index 7ebc7491e..73ece8958 100644
--- a/apps/browser-extension/tests/e2e/05-vault-merge.spec.ts
+++ b/apps/browser-extension/tests/e2e/05-vault-merge.spec.ts
@@ -90,20 +90,10 @@ test.describe.serial('5. Vault Merge', () => {
 
   test('5.5 Client A should see credentials after syncing', async () => {
     await clientA
-      .goToVault()
+      .triggerSync()
       .then((c) => c.verifyCredentialExists(credentialNameA))
       .then((c) => c.screenshot('5.5-client-a-vault-state.png'));
 
-    const clientBCredential = clientA.popup.locator(`text=${credentialNameB}`);
-    const hasBothCredentials = await clientBCredential.isVisible().catch(() => false);
-
-    if (hasBothCredentials) {
-      await clientA.screenshot('5.5-client-a-synced-both.png');
-      await clientA.verifyVaultItemCount(2);
-    } else {
-      await clientA.screenshot('5.5-client-a-only-own-credential.png');
-      const itemsText = clientA.popup.locator('text=/\\(1 items?\\)/');
-      await expect(itemsText).toBeVisible({ timeout: 5000 });
-    }
+    await clientA.verifyVaultItemCount(2);
   });
 });
diff --git a/apps/browser-extension/tests/fixtures/TestClient.ts b/apps/browser-extension/tests/fixtures/TestClient.ts
index fdc2efa51..2c105d1b2 100644
--- a/apps/browser-extension/tests/fixtures/TestClient.ts
+++ b/apps/browser-extension/tests/fixtures/TestClient.ts
@@ -303,8 +303,8 @@ export class TestClient {
    * Verify the vault shows a specific item count.
    */
   async verifyVaultItemCount(count: number): Promise<this> {
-    const itemsText = this.popup.locator(`text=/\\(${count} items?\\)/`);
-    await expect(itemsText).toBeVisible({ timeout: Timeouts.SHORT });
+    const itemsList = this.popup.locator('ul#items-list > li');
+    await expect(itemsList).toHaveCount(count, { timeout: Timeouts.SHORT });
     return this;
   }