From a5f4621fda50df73ffcb191e9c2ed662220600dd Mon Sep 17 00:00:00 2001 From: Louis Erbkamm Date: Sun, 31 May 2026 14:24:24 +0200 Subject: [PATCH] ci: don't swallow a following flag as --resolution value Per PR review: `--resolution --duplicates N` stored the literal "--duplicates" as the resolution. Only consume the next arg if it isn't another flag. Co-Authored-By: Claude Opus 4.8 (1M context) --- .github/scripts/comment-on-issue.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/scripts/comment-on-issue.sh b/.github/scripts/comment-on-issue.sh index 3fa0534..03262c0 100755 --- a/.github/scripts/comment-on-issue.sh +++ b/.github/scripts/comment-on-issue.sh @@ -23,8 +23,10 @@ while (($#)); do ;; --resolution) shift - resolution="${1-}" - (($#)) && shift + # Only take the next arg if it's a real value, not another flag (or end of args). + if (($#)) && [[ "$1" != --* ]]; then + resolution="$1"; shift + fi ;; *) # Tolerate bare issue numbers as duplicates; reject anything else.