From 181bbe3368ca7ebc58697b030465052744e53619 Mon Sep 17 00:00:00 2001
From: Erik Vroon <erik.vroon22@gmail.com>
Date: Sat, 17 Feb 2024 14:31:07 +0100
Subject: [PATCH] SWR: Keep cache when mutating (#484)

---
 frontend/src/components/builder/builder.tsx            | 4 ++--
 frontend/src/components/buttons/create_stage.tsx       | 4 ++--
 frontend/src/components/modals/club_modal.tsx          | 2 +-
 frontend/src/components/modals/create_stage_item.tsx   | 2 +-
 frontend/src/components/modals/match_modal.tsx         | 8 ++++----
 frontend/src/components/modals/player_create_modal.tsx | 4 ++--
 frontend/src/components/modals/player_update_modal.tsx | 2 +-
 frontend/src/components/modals/round_modal.tsx         | 6 +++---
 frontend/src/components/modals/team_create_modal.tsx   | 4 ++--
 frontend/src/components/modals/team_update_modal.tsx   | 2 +-
 frontend/src/components/modals/tournament_modal.tsx    | 2 +-
 frontend/src/components/modals/update_stage.tsx        | 2 +-
 frontend/src/components/modals/update_stage_item.tsx   | 2 +-
 frontend/src/components/tables/clubs.tsx               | 2 +-
 frontend/src/components/tables/courts.tsx              | 2 +-
 frontend/src/components/tables/players.tsx             | 2 +-
 frontend/src/components/tables/teams.tsx               | 2 +-
 frontend/src/components/tables/tournaments.tsx         | 2 +-
 frontend/src/components/tables/upcoming_matches.tsx    | 4 ++--
 frontend/src/pages/tournaments/[id]/courts.tsx         | 2 +-
 frontend/src/pages/tournaments/[id]/schedule.tsx       | 4 ++--
 frontend/src/pages/tournaments/[id]/settings.tsx       | 2 +-
 22 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/frontend/src/components/builder/builder.tsx b/frontend/src/components/builder/builder.tsx
index b6b8efee..74487bc9 100644
--- a/frontend/src/components/builder/builder.tsx
+++ b/frontend/src/components/builder/builder.tsx
@@ -111,7 +111,7 @@ function StageItemRow({
                 leftSection={<IconTrash size={rem(14)} />}
                 onClick={async () => {
                   await deleteStageItem(tournament.id, stageItem.id);
-                  await swrStagesResponse.mutate(null);
+                  await swrStagesResponse.mutate();
                 }}
                 color="red"
               >
@@ -193,7 +193,7 @@ function StageColumn({
               leftSection={<IconTrash size={rem(14)} />}
               onClick={async () => {
                 await deleteStage(tournament.id, stage.id);
-                await swrStagesResponse.mutate(null);
+                await swrStagesResponse.mutate();
               }}
               color="red"
             >
diff --git a/frontend/src/components/buttons/create_stage.tsx b/frontend/src/components/buttons/create_stage.tsx
index 6e880346..be143f7c 100644
--- a/frontend/src/components/buttons/create_stage.tsx
+++ b/frontend/src/components/buttons/create_stage.tsx
@@ -24,7 +24,7 @@ export default function CreateStageButton({
       style={{ marginRight: 10 }}
       onClick={async () => {
         await createStage(tournament.id);
-        await swrStagesResponse.mutate(null);
+        await swrStagesResponse.mutate();
       }}
       leftSection={<GoPlus size={24} />}
     >
@@ -50,7 +50,7 @@ export function CreateStageButtonLarge({
       style={{ marginRight: 10, width: '25%' }}
       onClick={async () => {
         await createStage(tournament.id);
-        await swrStagesResponse.mutate(null);
+        await swrStagesResponse.mutate();
       }}
       leftSection={<GoPlus size={24} />}
     >
diff --git a/frontend/src/components/modals/club_modal.tsx b/frontend/src/components/modals/club_modal.tsx
index e23b67fc..a4d48cf5 100644
--- a/frontend/src/components/modals/club_modal.tsx
+++ b/frontend/src/components/modals/club_modal.tsx
@@ -59,7 +59,7 @@ export default function ClubModal({
           onSubmit={form.onSubmit(async (values) => {
             if (is_create_form) await createClub(values.name);
             else await updateClub(club.id, values.name);
-            await swrClubsResponse.mutate(null);
+            await swrClubsResponse.mutate();
             setOpened(false);
           })}
         >
diff --git a/frontend/src/components/modals/create_stage_item.tsx b/frontend/src/components/modals/create_stage_item.tsx
index 3f5eef88..721244de 100644
--- a/frontend/src/components/modals/create_stage_item.tsx
+++ b/frontend/src/components/modals/create_stage_item.tsx
@@ -174,7 +174,7 @@ export function CreateStageItemModal({
               };
             });
             await createStageItem(tournament.id, stage.id, values.type, teamCount, inputs);
-            await swrStagesResponse.mutate(null);
+            await swrStagesResponse.mutate();
           })}
         >
           <Select
diff --git a/frontend/src/components/modals/match_modal.tsx b/frontend/src/components/modals/match_modal.tsx
index f8f5812e..d46d3ec0 100644
--- a/frontend/src/components/modals/match_modal.tsx
+++ b/frontend/src/components/modals/match_modal.tsx
@@ -35,8 +35,8 @@ function MatchDeleteButton({
       fullWidth
       onClick={async () => {
         await deleteMatch(tournamentData.id, match.id);
-        await swrRoundsResponse.mutate(null);
-        if (swrUpcomingMatchesResponse != null) await swrUpcomingMatchesResponse.mutate(null);
+        await swrRoundsResponse.mutate();
+        if (swrUpcomingMatchesResponse != null) await swrUpcomingMatchesResponse.mutate();
       }}
       style={{ marginTop: '1rem' }}
       size="sm"
@@ -111,8 +111,8 @@ export default function MatchModal({
               custom_margin_minutes: customMarginEnabled ? values.custom_margin_minutes : null,
             };
             await updateMatch(tournamentData.id, match.id, updatedMatch);
-            await swrStagesResponse.mutate(null);
-            if (swrUpcomingMatchesResponse != null) await swrUpcomingMatchesResponse.mutate(null);
+            await swrStagesResponse.mutate();
+            if (swrUpcomingMatchesResponse != null) await swrUpcomingMatchesResponse.mutate();
             setOpened(false);
           })}
         >
diff --git a/frontend/src/components/modals/player_create_modal.tsx b/frontend/src/components/modals/player_create_modal.tsx
index 57516699..1bea6c55 100644
--- a/frontend/src/components/modals/player_create_modal.tsx
+++ b/frontend/src/components/modals/player_create_modal.tsx
@@ -33,7 +33,7 @@ function MultiPlayerTab({
     <form
       onSubmit={form.onSubmit(async (values) => {
         await createMultiplePlayers(tournament_id, values.names, values.active);
-        await swrPlayersResponse.mutate(null);
+        await swrPlayersResponse.mutate();
         setOpened(false);
       })}
     >
@@ -75,7 +75,7 @@ function SinglePlayerTab({
     <form
       onSubmit={form.onSubmit(async (values) => {
         await createPlayer(tournament_id, values.name, values.active);
-        await swrPlayersResponse.mutate(null);
+        await swrPlayersResponse.mutate();
         setOpened(false);
       })}
     >
diff --git a/frontend/src/components/modals/player_update_modal.tsx b/frontend/src/components/modals/player_update_modal.tsx
index e4c0e9e7..b410f6e0 100644
--- a/frontend/src/components/modals/player_update_modal.tsx
+++ b/frontend/src/components/modals/player_update_modal.tsx
@@ -47,7 +47,7 @@ export default function PlayerUpdateModal({
         <form
           onSubmit={form.onSubmit(async (values) => {
             await updatePlayer(tournament_id, player.id, values.name, values.active, null);
-            await swrPlayersResponse.mutate(null);
+            await swrPlayersResponse.mutate();
             setOpened(false);
           })}
         >
diff --git a/frontend/src/components/modals/round_modal.tsx b/frontend/src/components/modals/round_modal.tsx
index 76a75e94..9145366f 100644
--- a/frontend/src/components/modals/round_modal.tsx
+++ b/frontend/src/components/modals/round_modal.tsx
@@ -38,8 +38,8 @@ function RoundDeleteButton({
       fullWidth
       onClick={async () => {
         await deleteRound(tournamentData.id, round.id);
-        await swrRoundsResponse.mutate(null);
-        if (swrUpcomingMatchesResponse != null) await swrUpcomingMatchesResponse.mutate(null);
+        await swrRoundsResponse.mutate();
+        if (swrUpcomingMatchesResponse != null) await swrUpcomingMatchesResponse.mutate();
       }}
       style={{ marginTop: '15px' }}
       size="sm"
@@ -82,7 +82,7 @@ export default function RoundModal({
         <form
           onSubmit={form.onSubmit(async (values) => {
             await updateRound(tournamentData.id, round.id, values as RoundInterface);
-            await swrRoundsResponse.mutate(null);
+            await swrRoundsResponse.mutate();
             setOpened(false);
           })}
         >
diff --git a/frontend/src/components/modals/team_create_modal.tsx b/frontend/src/components/modals/team_create_modal.tsx
index 7668c54c..2a497bfc 100644
--- a/frontend/src/components/modals/team_create_modal.tsx
+++ b/frontend/src/components/modals/team_create_modal.tsx
@@ -35,7 +35,7 @@ function MultiTeamTab({
     <form
       onSubmit={form.onSubmit(async (values) => {
         await createTeams(tournament_id, values.names, values.active);
-        await swrTeamsResponse.mutate(null);
+        await swrTeamsResponse.mutate();
         setOpened(false);
       })}
     >
@@ -79,7 +79,7 @@ function SingleTeamTab({
     <form
       onSubmit={form.onSubmit(async (values) => {
         await createTeam(tournament_id, values.name, values.active, values.player_ids);
-        await swrTeamsResponse.mutate(null);
+        await swrTeamsResponse.mutate();
         setOpened(false);
       })}
     >
diff --git a/frontend/src/components/modals/team_update_modal.tsx b/frontend/src/components/modals/team_update_modal.tsx
index d1e41fc5..bc808155 100644
--- a/frontend/src/components/modals/team_update_modal.tsx
+++ b/frontend/src/components/modals/team_update_modal.tsx
@@ -49,7 +49,7 @@ export default function TeamUpdateModal({
               values.player_ids
             );
             if (requestSucceeded(result)) {
-              await swrTeamsResponse.mutate(null);
+              await swrTeamsResponse.mutate();
               setOpened(false);
             }
           })}
diff --git a/frontend/src/components/modals/tournament_modal.tsx b/frontend/src/components/modals/tournament_modal.tsx
index b41a921f..90ffd42d 100644
--- a/frontend/src/components/modals/tournament_modal.tsx
+++ b/frontend/src/components/modals/tournament_modal.tsx
@@ -77,7 +77,7 @@ function GeneralTournamentForm({
           values.duration_minutes,
           values.margin_minutes
         );
-        await swrTournamentsResponse.mutate(null);
+        await swrTournamentsResponse.mutate();
         setOpened(false);
       })}
     >
diff --git a/frontend/src/components/modals/update_stage.tsx b/frontend/src/components/modals/update_stage.tsx
index 18abbd02..af7432b6 100644
--- a/frontend/src/components/modals/update_stage.tsx
+++ b/frontend/src/components/modals/update_stage.tsx
@@ -32,7 +32,7 @@ export function UpdateStageModal({
       <form
         onSubmit={form.onSubmit(async (values) => {
           await updateStage(tournament.id, stage.id, values.name);
-          await swrStagesResponse.mutate(null);
+          await swrStagesResponse.mutate();
         })}
       >
         <TextInput
diff --git a/frontend/src/components/modals/update_stage_item.tsx b/frontend/src/components/modals/update_stage_item.tsx
index a353aa8e..27753c61 100644
--- a/frontend/src/components/modals/update_stage_item.tsx
+++ b/frontend/src/components/modals/update_stage_item.tsx
@@ -32,7 +32,7 @@ export function UpdateStageItemModal({
       <form
         onSubmit={form.onSubmit(async (values) => {
           await updateStageItem(tournament.id, stageItem.id, values.name);
-          await swrStagesResponse.mutate(null);
+          await swrStagesResponse.mutate();
         })}
       >
         <TextInput
diff --git a/frontend/src/components/tables/clubs.tsx b/frontend/src/components/tables/clubs.tsx
index 804ee9b2..6d5a7a66 100644
--- a/frontend/src/components/tables/clubs.tsx
+++ b/frontend/src/components/tables/clubs.tsx
@@ -32,7 +32,7 @@ export default function ClubsTable({ swrClubsResponse }: { swrClubsResponse: SWR
           <DeleteButton
             onClick={async () => {
               await deleteClub(club.id);
-              await swrClubsResponse.mutate(null);
+              await swrClubsResponse.mutate();
             }}
             title={t('delete_club_button')}
           />
diff --git a/frontend/src/components/tables/courts.tsx b/frontend/src/components/tables/courts.tsx
index 4ada92bf..a792abd7 100644
--- a/frontend/src/components/tables/courts.tsx
+++ b/frontend/src/components/tables/courts.tsx
@@ -39,7 +39,7 @@ export default function CourtsTable({
           <DeleteButton
             onClick={async () => {
               await deleteCourt(tournament.id, court.id);
-              await swrCourtsResponse.mutate(null);
+              await swrCourtsResponse.mutate();
             }}
             title={t('delete_court_button')}
           />
diff --git a/frontend/src/components/tables/players.tsx b/frontend/src/components/tables/players.tsx
index 046705cf..485c25e0 100644
--- a/frontend/src/components/tables/players.tsx
+++ b/frontend/src/components/tables/players.tsx
@@ -103,7 +103,7 @@ export default function PlayersTable({
           <DeleteButton
             onClick={async () => {
               await deletePlayer(tournamentData.id, player.id);
-              await swrPlayersResponse.mutate(null);
+              await swrPlayersResponse.mutate();
             }}
             title={t('delete_player_button')}
           />
diff --git a/frontend/src/components/tables/teams.tsx b/frontend/src/components/tables/teams.tsx
index 8a50ec8d..8cef673f 100644
--- a/frontend/src/components/tables/teams.tsx
+++ b/frontend/src/components/tables/teams.tsx
@@ -62,7 +62,7 @@ export default function TeamsTable({
           <DeleteButton
             onClick={async () => {
               await deleteTeam(tournamentData.id, team.id);
-              await swrTeamsResponse.mutate(null);
+              await swrTeamsResponse.mutate();
             }}
             title={t('delete_team_button')}
           />
diff --git a/frontend/src/components/tables/tournaments.tsx b/frontend/src/components/tables/tournaments.tsx
index f8c29760..4cb33373 100644
--- a/frontend/src/components/tables/tournaments.tsx
+++ b/frontend/src/components/tables/tournaments.tsx
@@ -57,7 +57,7 @@ export default function TournamentsTable({
           <DeleteButton
             onClick={async () => {
               await deleteTournament(tournament.id);
-              await swrTournamentsResponse.mutate(null);
+              await swrTournamentsResponse.mutate();
             }}
             title={t('delete_tournament_button')}
           />
diff --git a/frontend/src/components/tables/upcoming_matches.tsx b/frontend/src/components/tables/upcoming_matches.tsx
index 0722c4b4..7c154d19 100644
--- a/frontend/src/components/tables/upcoming_matches.tsx
+++ b/frontend/src/components/tables/upcoming_matches.tsx
@@ -50,8 +50,8 @@ export default function UpcomingMatchesTable({
 
       await createMatch(tournamentData.id, match_to_schedule);
     }
-    await swrRoundsResponse.mutate(null);
-    await swrUpcomingMatchesResponse.mutate(null);
+    await swrRoundsResponse.mutate();
+    await swrUpcomingMatchesResponse.mutate();
   }
 
   const rows = upcoming_matches
diff --git a/frontend/src/pages/tournaments/[id]/courts.tsx b/frontend/src/pages/tournaments/[id]/courts.tsx
index 1bbc47d9..9dd1bcf4 100644
--- a/frontend/src/pages/tournaments/[id]/courts.tsx
+++ b/frontend/src/pages/tournaments/[id]/courts.tsx
@@ -25,7 +25,7 @@ function CreateCourtForm(t: Translator, tournament: Tournament, swrCourtsRespons
     <form
       onSubmit={form.onSubmit(async (values) => {
         await createCourt(tournament.id, values.name);
-        await swrCourtsResponse.mutate(null);
+        await swrCourtsResponse.mutate();
       })}
     >
       <Divider mt={12} />
diff --git a/frontend/src/pages/tournaments/[id]/schedule.tsx b/frontend/src/pages/tournaments/[id]/schedule.tsx
index 49a6bc95..caec58fc 100644
--- a/frontend/src/pages/tournaments/[id]/schedule.tsx
+++ b/frontend/src/pages/tournaments/[id]/schedule.tsx
@@ -187,7 +187,7 @@ export default function SchedulePage() {
               leftSection={<IconCalendarPlus size={24} />}
               onClick={async () => {
                 await scheduleMatches(tournamentData.id);
-                await swrStagesResponse.mutate(null);
+                await swrStagesResponse.mutate();
               }}
             >
               {t('schedule_description')}
@@ -205,7 +205,7 @@ export default function SchedulePage() {
               new_court_id: +destination.droppableId,
               new_position: destination.index,
             });
-            await swrStagesResponse.mutate(null);
+            await swrStagesResponse.mutate();
           }}
         >
           <Schedule
diff --git a/frontend/src/pages/tournaments/[id]/settings.tsx b/frontend/src/pages/tournaments/[id]/settings.tsx
index ef74700d..ac8b09de 100644
--- a/frontend/src/pages/tournaments/[id]/settings.tsx
+++ b/frontend/src/pages/tournaments/[id]/settings.tsx
@@ -88,7 +88,7 @@ function GeneralTournamentForm({
           values.margin_minutes
         );
 
-        await swrTournamentResponse.mutate(null);
+        await swrTournamentResponse.mutate();
       })}
     >
       <TextInput