From 0971f74a4ccab0b5ccaa4c8b6dabc85a84b6b84a Mon Sep 17 00:00:00 2001
From: Karl Seguin <k@openmymind.io>
Date: Fri, 5 Jun 2026 07:01:01 +0800
Subject: [PATCH] fix XMLHttpRequestUpload release

---
 src/browser/webapi/net/XMLHttpRequest.zig     |  3 +--
 .../webapi/net/XMLHttpRequestUpload.zig       | 20 +++++++++----------
 2 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/src/browser/webapi/net/XMLHttpRequest.zig b/src/browser/webapi/net/XMLHttpRequest.zig
index f303c080..974a8577 100644
--- a/src/browser/webapi/net/XMLHttpRequest.zig
+++ b/src/browser/webapi/net/XMLHttpRequest.zig
@@ -116,9 +116,8 @@ pub fn deinit(self: *XMLHttpRequest, page: *Page) void {
 
     self._proto.releaseListeners();
     if (self._upload) |upload| {
-        upload.deinit(page);
+        upload._proto.releaseListeners();
     }
-
     page.releaseArena(self._arena);
 }
 
diff --git a/src/browser/webapi/net/XMLHttpRequestUpload.zig b/src/browser/webapi/net/XMLHttpRequestUpload.zig
index b415ec7f..84b44015 100644
--- a/src/browser/webapi/net/XMLHttpRequestUpload.zig
+++ b/src/browser/webapi/net/XMLHttpRequestUpload.zig
@@ -35,22 +35,22 @@ const XMLHttpRequestUpload = @This();
 _proto: *XMLHttpRequestEventTarget,
 _xhr: *XMLHttpRequest,
 
-pub fn deinit(self: *XMLHttpRequestUpload, _: *Page) void {
-    self._proto.releaseListeners();
+// pub fn deinit(self: *XMLHttpRequestUpload, _: *Page) void {
+//     self._proto.releaseListeners();
+// }
+
+pub fn releaseRef(self: *XMLHttpRequestUpload, page: *Page) void {
+    self._xhr.releaseRef(page);
+}
+
+pub fn acquireRef(self: *XMLHttpRequestUpload) void {
+    self._xhr.acquireRef();
 }
 
 pub fn asEventTarget(self: *XMLHttpRequestUpload) *EventTarget {
     return self._proto.asEventTarget();
 }
 
-pub fn releaseRef(self: *XMLHttpRequestUpload, page: *Page) void {
-    self._xhr._rc.release(self, page);
-}
-
-pub fn acquireRef(self: *XMLHttpRequestUpload) void {
-    self._xhr._rc.acquire();
-}
-
 pub const JsApi = struct {
     pub const bridge = js.Bridge(XMLHttpRequestUpload);