From 0a8f4ff75f378645d8955a376d3937c3d960b37f Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Thu, 23 Apr 2026 16:18:20 +0800 Subject: [PATCH] Remove unused imports As a general rule, I keep `std` if its there and unused, mostly for debug.print debugging. --- src/browser/EventManager.zig | 1 - src/browser/HttpClient.zig | 2 -- src/browser/actions.zig | 1 - src/browser/js/Caller.zig | 1 - src/browser/js/Context.zig | 1 - src/browser/js/Env.zig | 1 - src/browser/js/Identity.zig | 2 -- src/browser/js/Local.zig | 1 - src/browser/js/Snapshot.zig | 1 - src/browser/js/bridge.zig | 1 - src/browser/webapi/AbstractRange.zig | 1 - src/browser/webapi/Event.zig | 1 - src/browser/webapi/EventTarget.zig | 1 - src/browser/webapi/IntersectionObserver.zig | 1 - src/browser/webapi/KeyValueList.zig | 1 - src/browser/webapi/MutationObserver.zig | 1 - src/browser/webapi/Range.zig | 1 - src/browser/webapi/Worker.zig | 1 - src/browser/webapi/collections/ChildNodes.zig | 1 + src/browser/webapi/collections/iterator.zig | 3 --- src/browser/webapi/element/html/Canvas.zig | 2 -- src/browser/webapi/element/html/Form.zig | 1 - src/browser/webapi/element/html/IFrame.zig | 1 - src/browser/webapi/element/html/Image.zig | 1 - src/browser/webapi/element/html/Link.zig | 1 - src/browser/webapi/element/html/Script.zig | 1 - src/browser/webapi/net/Request.zig | 2 +- src/browser/webapi/selector/Parser.zig | 2 -- src/cookies.zig | 1 - src/network/cache/FsCache.zig | 3 +-- 30 files changed, 3 insertions(+), 36 deletions(-) diff --git a/src/browser/EventManager.zig b/src/browser/EventManager.zig index cabc56a3..77cb47b0 100644 --- a/src/browser/EventManager.zig +++ b/src/browser/EventManager.zig @@ -30,7 +30,6 @@ const EventTarget = @import("webapi/EventTarget.zig"); const Element = @import("webapi/Element.zig"); const log = lp.log; -const String = lp.String; const Allocator = std.mem.Allocator; // Re-export types from EventManagerBase for API compatibility diff --git a/src/browser/HttpClient.zig b/src/browser/HttpClient.zig index 241ae687..bc31adc2 100644 --- a/src/browser/HttpClient.zig +++ b/src/browser/HttpClient.zig @@ -21,10 +21,8 @@ const lp = @import("lightpanda"); const builtin = @import("builtin"); const URL = @import("URL.zig"); -const Config = @import("../Config.zig"); const Notification = @import("../Notification.zig"); const CookieJar = @import("webapi/storage/Cookie.zig").Jar; -const WebSocket = @import("webapi/net/WebSocket.zig"); const http = @import("../network/http.zig"); const Network = @import("../network/Network.zig"); diff --git a/src/browser/actions.zig b/src/browser/actions.zig index 9380de04..54868951 100644 --- a/src/browser/actions.zig +++ b/src/browser/actions.zig @@ -25,7 +25,6 @@ const MouseEvent = @import("webapi/event/MouseEvent.zig"); const KeyboardEvent = @import("webapi/event/KeyboardEvent.zig"); const Frame = @import("Frame.zig"); const Session = @import("Session.zig"); -const Selector = @import("webapi/selector/Selector.zig"); fn dispatchInputAndChangeEvents(el: *Element, frame: *Frame) !void { const input_evt: *Event = try .initTrusted(comptime .wrap("input"), .{ .bubbles = true }, frame._page); diff --git a/src/browser/js/Caller.zig b/src/browser/js/Caller.zig index 4df8813a..0cbf9e11 100644 --- a/src/browser/js/Caller.zig +++ b/src/browser/js/Caller.zig @@ -23,7 +23,6 @@ const string = @import("../../string.zig"); const Frame = @import("../Frame.zig"); const Page = @import("../Page.zig"); const Session = @import("../Session.zig"); -const WorkerGlobalScope = @import("../webapi/WorkerGlobalScope.zig"); const js = @import("js.zig"); const Local = @import("Local.zig"); diff --git a/src/browser/js/Context.zig b/src/browser/js/Context.zig index b880ce6e..9811eb3d 100644 --- a/src/browser/js/Context.zig +++ b/src/browser/js/Context.zig @@ -20,7 +20,6 @@ const std = @import("std"); const lp = @import("lightpanda"); const js = @import("js.zig"); -const bridge = @import("bridge.zig"); const Env = @import("Env.zig"); const Origin = @import("Origin.zig"); const Scheduler = @import("Scheduler.zig"); diff --git a/src/browser/js/Env.zig b/src/browser/js/Env.zig index 2d4a7b15..7754d8a3 100644 --- a/src/browser/js/Env.zig +++ b/src/browser/js/Env.zig @@ -25,7 +25,6 @@ const bridge = @import("bridge.zig"); const Context = @import("Context.zig"); const Isolate = @import("Isolate.zig"); const Platform = @import("Platform.zig"); -const Snapshot = @import("Snapshot.zig"); const Inspector = @import("Inspector.zig"); const App = @import("../../App.zig"); diff --git a/src/browser/js/Identity.zig b/src/browser/js/Identity.zig index e101003e..8c14cdc2 100644 --- a/src/browser/js/Identity.zig +++ b/src/browser/js/Identity.zig @@ -29,8 +29,6 @@ const std = @import("std"); const js = @import("js.zig"); -const Session = @import("../Session.zig"); - const v8 = js.v8; const Identity = @This(); diff --git a/src/browser/js/Local.zig b/src/browser/js/Local.zig index 3e810f31..0a7b120f 100644 --- a/src/browser/js/Local.zig +++ b/src/browser/js/Local.zig @@ -33,7 +33,6 @@ const TaggedOpaque = @import("TaggedOpaque.zig"); const v8 = js.v8; const log = lp.log; const CallOpts = Caller.CallOpts; -const IS_DEBUG = @import("builtin").mode == .Debug; // Where js.Context has a lifetime tied to the frame, and holds the // v8::Global, this has a much shorter lifetime and holds a diff --git a/src/browser/js/Snapshot.zig b/src/browser/js/Snapshot.zig index 1fb61290..517bf313 100644 --- a/src/browser/js/Snapshot.zig +++ b/src/browser/js/Snapshot.zig @@ -21,7 +21,6 @@ const lp = @import("lightpanda"); const js = @import("js.zig"); const bridge = @import("bridge.zig"); -const WebDriver = @import("../webapi/WebDriver.zig"); const v8 = js.v8; const log = lp.log; diff --git a/src/browser/js/bridge.zig b/src/browser/js/bridge.zig index e61818c7..29dd52d4 100644 --- a/src/browser/js/bridge.zig +++ b/src/browser/js/bridge.zig @@ -21,7 +21,6 @@ const lp = @import("lightpanda"); const js = @import("js.zig"); const Frame = @import("../Frame.zig"); -const Session = @import("../Session.zig"); const v8 = js.v8; diff --git a/src/browser/webapi/AbstractRange.zig b/src/browser/webapi/AbstractRange.zig index 46af8b3f..2a530d9b 100644 --- a/src/browser/webapi/AbstractRange.zig +++ b/src/browser/webapi/AbstractRange.zig @@ -26,7 +26,6 @@ const Node = @import("Node.zig"); const Range = @import("Range.zig"); const Allocator = std.mem.Allocator; -const IS_DEBUG = @import("builtin").mode == .Debug; const AbstractRange = @This(); diff --git a/src/browser/webapi/Event.zig b/src/browser/webapi/Event.zig index 5692efe6..f08914e8 100644 --- a/src/browser/webapi/Event.zig +++ b/src/browser/webapi/Event.zig @@ -28,7 +28,6 @@ const EventTarget = @import("EventTarget.zig"); const String = lp.String; const Allocator = std.mem.Allocator; -const IS_DEBUG = @import("builtin").mode == .Debug; pub const Event = @This(); diff --git a/src/browser/webapi/EventTarget.zig b/src/browser/webapi/EventTarget.zig index 1e390900..c2c19310 100644 --- a/src/browser/webapi/EventTarget.zig +++ b/src/browser/webapi/EventTarget.zig @@ -23,7 +23,6 @@ const Page = @import("../Page.zig"); const EventManager = @import("../EventManager.zig"); const Event = @import("Event.zig"); -const WorkerGlobalScope = @import("WorkerGlobalScope.zig"); const RegisterOptions = EventManager.RegisterOptions; diff --git a/src/browser/webapi/IntersectionObserver.zig b/src/browser/webapi/IntersectionObserver.zig index 64e4e594..f38eca3c 100644 --- a/src/browser/webapi/IntersectionObserver.zig +++ b/src/browser/webapi/IntersectionObserver.zig @@ -29,7 +29,6 @@ const DOMRect = @import("DOMRect.zig"); const log = lp.log; const Allocator = std.mem.Allocator; -const IS_DEBUG = @import("builtin").mode == .Debug; pub fn registerTypes() []const type { return &.{ diff --git a/src/browser/webapi/KeyValueList.zig b/src/browser/webapi/KeyValueList.zig index 33997e4e..cb4e7c50 100644 --- a/src/browser/webapi/KeyValueList.zig +++ b/src/browser/webapi/KeyValueList.zig @@ -20,7 +20,6 @@ const std = @import("std"); const lp = @import("lightpanda"); const js = @import("../js/js.zig"); -const Frame = @import("../Frame.zig"); const h5e = @import("../parser/html5ever.zig"); const String = lp.String; diff --git a/src/browser/webapi/MutationObserver.zig b/src/browser/webapi/MutationObserver.zig index 2e538207..c7b40190 100644 --- a/src/browser/webapi/MutationObserver.zig +++ b/src/browser/webapi/MutationObserver.zig @@ -29,7 +29,6 @@ const Element = @import("Element.zig"); const log = lp.log; const String = lp.String; const Allocator = std.mem.Allocator; -const IS_DEBUG = @import("builtin").mode == .Debug; pub fn registerTypes() []const type { return &.{ diff --git a/src/browser/webapi/Range.zig b/src/browser/webapi/Range.zig index 0203aa5a..c1eb3fde 100644 --- a/src/browser/webapi/Range.zig +++ b/src/browser/webapi/Range.zig @@ -21,7 +21,6 @@ const lp = @import("lightpanda"); const js = @import("../js/js.zig"); const Frame = @import("../Frame.zig"); -const Session = @import("../Session.zig"); const Node = @import("Node.zig"); const DocumentFragment = @import("DocumentFragment.zig"); diff --git a/src/browser/webapi/Worker.zig b/src/browser/webapi/Worker.zig index 86eb985f..558d4cce 100644 --- a/src/browser/webapi/Worker.zig +++ b/src/browser/webapi/Worker.zig @@ -20,7 +20,6 @@ const std = @import("std"); const lp = @import("lightpanda"); const js = @import("../js/js.zig"); -const http = @import("../../network/http.zig"); const URL = @import("../URL.zig"); const Frame = @import("../Frame.zig"); diff --git a/src/browser/webapi/collections/ChildNodes.zig b/src/browser/webapi/collections/ChildNodes.zig index 0bda6560..1fa3b180 100644 --- a/src/browser/webapi/collections/ChildNodes.zig +++ b/src/browser/webapi/collections/ChildNodes.zig @@ -23,6 +23,7 @@ const Page = @import("../../Page.zig"); const Frame = @import("../../Frame.zig"); const Node = @import("../Node.zig"); + const GenericIterator = @import("iterator.zig").Entry; // Optimized for node.childNodes, which has to be a live list. diff --git a/src/browser/webapi/collections/iterator.zig b/src/browser/webapi/collections/iterator.zig index ab45d708..a9833618 100644 --- a/src/browser/webapi/collections/iterator.zig +++ b/src/browser/webapi/collections/iterator.zig @@ -21,9 +21,6 @@ const lp = @import("lightpanda"); const js = @import("../../js/js.zig"); const Page = @import("../../Page.zig"); -const Frame = @import("../../Frame.zig"); - -const Execution = js.Execution; pub fn Entry(comptime Inner: type, comptime field: ?[]const u8) type { const R = reflect(Inner, field); diff --git a/src/browser/webapi/element/html/Canvas.zig b/src/browser/webapi/element/html/Canvas.zig index afb43da2..c8fc7d1d 100644 --- a/src/browser/webapi/element/html/Canvas.zig +++ b/src/browser/webapi/element/html/Canvas.zig @@ -31,8 +31,6 @@ const Canvas = @This(); _proto: *HtmlElement, _cached: ?DrawingContext = null, -const ContextType = enum { none, @"2d", webgl }; - pub fn asElement(self: *Canvas) *Element { return self._proto._proto; } diff --git a/src/browser/webapi/element/html/Form.zig b/src/browser/webapi/element/html/Form.zig index 55d92f97..eeb5031e 100644 --- a/src/browser/webapi/element/html/Form.zig +++ b/src/browser/webapi/element/html/Form.zig @@ -18,7 +18,6 @@ const std = @import("std"); const js = @import("../../../js/js.zig"); -const URL = @import("../../../URL.zig"); const Frame = @import("../../../Frame.zig"); const Node = @import("../../Node.zig"); diff --git a/src/browser/webapi/element/html/IFrame.zig b/src/browser/webapi/element/html/IFrame.zig index 440179ba..e3b93ca3 100644 --- a/src/browser/webapi/element/html/IFrame.zig +++ b/src/browser/webapi/element/html/IFrame.zig @@ -23,7 +23,6 @@ const Document = @import("../../Document.zig"); const Node = @import("../../Node.zig"); const Element = @import("../../Element.zig"); const HtmlElement = @import("../Html.zig"); -const URL = @import("../../URL.zig"); const IFrame = @This(); _proto: *HtmlElement, diff --git a/src/browser/webapi/element/html/Image.zig b/src/browser/webapi/element/html/Image.zig index 75e115e4..ab60c943 100644 --- a/src/browser/webapi/element/html/Image.zig +++ b/src/browser/webapi/element/html/Image.zig @@ -1,7 +1,6 @@ const std = @import("std"); const js = @import("../../../js/js.zig"); const Frame = @import("../../../Frame.zig"); -const URL = @import("../../../URL.zig"); const Node = @import("../../Node.zig"); const Element = @import("../../Element.zig"); const HtmlElement = @import("../Html.zig"); diff --git a/src/browser/webapi/element/html/Link.zig b/src/browser/webapi/element/html/Link.zig index dad4f533..a1a14874 100644 --- a/src/browser/webapi/element/html/Link.zig +++ b/src/browser/webapi/element/html/Link.zig @@ -20,7 +20,6 @@ const std = @import("std"); const js = @import("../../../js/js.zig"); const Frame = @import("../../../Frame.zig"); -const URL = @import("../../URL.zig"); const Node = @import("../../Node.zig"); const Element = @import("../../Element.zig"); const HtmlElement = @import("../Html.zig"); diff --git a/src/browser/webapi/element/html/Script.zig b/src/browser/webapi/element/html/Script.zig index c77be0e3..2133090a 100644 --- a/src/browser/webapi/element/html/Script.zig +++ b/src/browser/webapi/element/html/Script.zig @@ -23,7 +23,6 @@ const Frame = @import("../../../Frame.zig"); const Node = @import("../../Node.zig"); const Element = @import("../../Element.zig"); const HtmlElement = @import("../Html.zig"); -const URL = @import("../../URL.zig"); const Script = @This(); diff --git a/src/browser/webapi/net/Request.zig b/src/browser/webapi/net/Request.zig index 5d749e6d..50dfc87f 100644 --- a/src/browser/webapi/net/Request.zig +++ b/src/browser/webapi/net/Request.zig @@ -22,10 +22,10 @@ const js = @import("../../js/js.zig"); const http = @import("../../../network/http.zig"); const URL = @import("../URL.zig"); -const Frame = @import("../../Frame.zig"); const Headers = @import("Headers.zig"); const Blob = @import("../Blob.zig"); const AbortSignal = @import("../AbortSignal.zig"); + const Execution = js.Execution; const Allocator = std.mem.Allocator; diff --git a/src/browser/webapi/selector/Parser.zig b/src/browser/webapi/selector/Parser.zig index 0028defe..947b0211 100644 --- a/src/browser/webapi/selector/Parser.zig +++ b/src/browser/webapi/selector/Parser.zig @@ -18,8 +18,6 @@ const std = @import("std"); -const Frame = @import("../../Frame.zig"); - const Node = @import("../Node.zig"); const Attribute = @import("../element/Attribute.zig"); diff --git a/src/cookies.zig b/src/cookies.zig index 211322ad..4805c4f5 100644 --- a/src/cookies.zig +++ b/src/cookies.zig @@ -20,7 +20,6 @@ const Session = @import("browser/Session.zig"); const Cookie = @import("browser/webapi/storage/Cookie.zig"); const log = lp.log; -const Allocator = std.mem.Allocator; /// Load cookies from a JSON file into the cookie jar. /// The file format is an array of objects with: name, value, domain, path, diff --git a/src/network/cache/FsCache.zig b/src/network/cache/FsCache.zig index 532d0f73..4f0b8a8a 100644 --- a/src/network/cache/FsCache.zig +++ b/src/network/cache/FsCache.zig @@ -20,7 +20,6 @@ const std = @import("std"); const lp = @import("lightpanda"); const Cache = @import("Cache.zig"); -const Http = @import("../http.zig"); const log = lp.log; const CacheRequest = Cache.CacheRequest; @@ -89,7 +88,7 @@ pub fn deinit(self: *FsCache) void { self.dir.close(); } -pub fn get(self: *FsCache, arena: std.mem.Allocator, req: CacheRequest) ?Cache.CachedResponse { +pub fn get(self: *FsCache, arena: std.mem.Allocator, req: CacheRequest) ?CachedResponse { const hashed_key = hashKey(req.url); const cache_p = cachePath(&hashed_key);