page-a
diff --git a/src/browser/tests/cdp/semantic_tree_frame_b.html b/src/browser/tests/cdp/semantic_tree_frame_b.html deleted file mode 100644 index 967adff52..000000000 --- a/src/browser/tests/cdp/semantic_tree_frame_b.html +++ /dev/null @@ -1 +0,0 @@ -inner-b
parent-probe
+ diff --git a/src/browser/tests/cdp/semantic_tree_iframe_child.html b/src/browser/tests/cdp/semantic_tree_iframe_child.html new file mode 100644 index 000000000..59f1e8264 --- /dev/null +++ b/src/browser/tests/cdp/semantic_tree_iframe_child.html @@ -0,0 +1,4 @@ + + + +child-probe
diff --git a/src/browser/tools.zig b/src/browser/tools.zig index a1e90042a..5f90c164a 100644 --- a/src/browser/tools.zig +++ b/src/browser/tools.zig @@ -1430,11 +1430,12 @@ fn execTree(arena: std.mem.Allocator, session: *lp.Session, registry: *NodeRegis const page = try ensurePage(session, registry, args.url, args.timeout); const root_node = (try resolveOptionalNode(registry, args.backendNodeId)) orelse page.document.asNode(); + const frame = root_node.ownerFrame(page) orelse return ToolError.NodeNotFound; const st = lp.SemanticTree{ .dom_node = root_node, .registry = registry, - .frame = page, + .frame = frame, .arena = arena, .prune = true, .max_depth = args.maxDepth orelse std.math.maxInt(u32) - 1, @@ -1453,7 +1454,8 @@ fn execNodeDetails(arena: std.mem.Allocator, session: *lp.Session, registry: *No const node = registry.lookup_by_id.get(args.backendNodeId) orelse return ToolError.NodeNotFound; - const details = lp.SemanticTree.getNodeDetails(arena, node.dom, registry, page) catch + const frame = node.dom.ownerFrame(page) orelse return ToolError.NodeNotFound; + const details = lp.SemanticTree.getNodeDetails(arena, node.dom, registry, frame) catch return ToolError.InternalError; return renderJson(arena, &details); } diff --git a/src/server/cdp/domains/lp.zig b/src/server/cdp/domains/lp.zig index 716eb5a46..bbcf957a5 100644 --- a/src/server/cdp/domains/lp.zig +++ b/src/server/cdp/domains/lp.zig @@ -127,12 +127,13 @@ fn getSemanticTree(cmd: anytype) !void { const params = (try cmd.params(Params)) orelse Params{}; const bc = cmd.browser_context orelse return error.NoBrowserContext; - const frame = bc.mainFrame() orelse return error.FrameNotLoaded; + const root = bc.mainFrame() orelse return error.FrameNotLoaded; const dom_node = if (params.backendNodeId) |nodeId| (bc.node_registry.lookup_by_id.get(nodeId) orelse return error.InvalidNodeId).dom else - frame.document.asNode(); + root.document.asNode(); + const frame = dom_node.ownerFrame(root) orelse return error.InvalidNodeId; var st = SemanticTree{ .dom_node = dom_node, @@ -269,9 +270,10 @@ fn getNodeDetails(cmd: anytype) !void { const params = (try cmd.params(Params)) orelse return error.InvalidParam; const bc = cmd.browser_context orelse return error.NoBrowserContext; - const frame = bc.mainFrame() orelse return error.FrameNotLoaded; + const root = bc.mainFrame() orelse return error.FrameNotLoaded; const node = (bc.node_registry.lookup_by_id.get(params.backendNodeId) orelse return error.InvalidNodeId).dom; + const frame = node.ownerFrame(root) orelse return error.InvalidNodeId; const details = SemanticTree.getNodeDetails(cmd.arena, node, &bc.node_registry, frame) catch return error.InternalError; @@ -616,6 +618,43 @@ test "cdp.lp: dump formats, strip and scoping" { try testing.expect((try dumpReply(&ctx, 9)).get("error") != null); } +// A backendNodeId can name a node in a child frame while the handler only +// knows the root. Labels, datalists and styles must come from the node's own +// document: the parent reuses every id and hides `.probe`. +test "cdp.lp: semantic tree and node details read the node's own frame" { + var ctx = try testing.context(); + defer ctx.deinit(); + + const bc = try ctx.loadBrowserContext(.{ .id = "BID-T", .url = "cdp/semantic_tree_iframe.html", .target_id = "FID-000000000T".* }); + const root = bc.mainFrame() orelse unreachable; + const child = root.child_frames.items[0]; + + const html = (child.document.getDocumentElement() orelse unreachable).asNode(); + const input = (try child.document.querySelector(.wrap("input"), child)).?.asNode(); + const html_id = (try bc.node_registry.register(html)).id; + const input_id = (try bc.node_registry.register(input)).id; + + try ctx.processMessage(.{ .id = 1, .method = "LP.getSemanticTree", .params = .{ .backendNodeId = html_id, .format = "text", .prune = false } }); + const tree = (try dumpReply(&ctx, 1)).get("result").?.object.get("semanticTree").?.string; + try testing.expect(std.mem.indexOf(u8, tree, "child-label") != null); + try testing.expect(std.mem.indexOf(u8, tree, "child-option") != null); + try testing.expect(std.mem.indexOf(u8, tree, "child-probe") != null); + try testing.expect(std.mem.indexOf(u8, tree, "parent-") == null); + + try ctx.processMessage(.{ .id = 2, .method = "LP.getNodeDetails", .params = .{ .backendNodeId = input_id } }); + const details = (try dumpReply(&ctx, 2)).get("result").?.object.get("nodeDetails").?.object; + try testing.expectEqual("child-label", details.get("name").?.string); + try testing.expectEqual("child-option", details.get("options").?.array.items[0].object.get("value").?.string); + + // A document with no frame has no styles or layout to describe. + const frameless = try root._factory.genericDocument(.{}); + const frameless_id = (try bc.node_registry.register(frameless.asNode())).id; + try ctx.processMessage(.{ .id = 3, .method = "LP.getSemanticTree", .params = .{ .backendNodeId = frameless_id } }); + try ctx.expectSentError(-31998, "InvalidNodeId", .{ .id = 3 }); + try ctx.processMessage(.{ .id = 4, .method = "LP.getNodeDetails", .params = .{ .backendNodeId = frameless_id } }); + try ctx.expectSentError(-31998, "InvalidNodeId", .{ .id = 4 }); +} + test "cdp.lp: getInteractiveElements" { var ctx = try testing.context(); defer ctx.deinit();