From 72d612472deb02500451c711b374329159d8b71c Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Mon, 28 Sep 2026 10:34:59 +0800 Subject: [PATCH] ci: fix flaky test --- src/browser/Runner.zig | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/browser/Runner.zig b/src/browser/Runner.zig index 1c3bf3b68..0fb715fb1 100644 --- a/src/browser/Runner.zig +++ b/src/browser/Runner.zig @@ -633,11 +633,14 @@ test "Runner: waits out a throttled navigation" { network.rate_limiter.?.deinit(); network.rate_limiter = null; } - const start = lp.datetime.milliTimestamp(.boot); - _ = try network.rate_limiter.?.reserve("127.0.0.1", start); const page = try session.createPage(); defer page.close(); + + // Reserved after createPage: on a slow runner, creating the page can eat + // the whole interval and the navigation then goes out undelayed. + const start = lp.datetime.milliTimestamp(.boot); + _ = try network.rate_limiter.?.reserve("127.0.0.1", start); try page.navigate("http://127.0.0.1:9582/src/browser/tests/runner/runner1.html", .{}); try testing.expectEqual(1, http_client.delayed_count); // A delayed navigation is in-flight work: the wait must not resolve early.