From 9661204c8d05e871c958f9f4330be58226886f35 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Wed, 1 Apr 2026 17:22:38 +0200 Subject: [PATCH] percent encode version query string for crash report --- build.zig | 6 +++++- src/crash_handler.zig | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/build.zig b/build.zig index 4fba3dc9..5aa44660 100644 --- a/build.zig +++ b/build.zig @@ -46,8 +46,12 @@ pub fn build(b: *Build) !void { var stdout = std.fs.File.stdout().writer(&.{}); try stdout.interface.print("Lightpanda {f}\n", .{version}); + const version_string = b.fmt("{f}", .{version}); + const version_encoded = std.mem.replaceOwned(u8, b.allocator, version_string, "+", "%2B") catch @panic("OOM"); + var opts = b.addOptions(); - opts.addOption([]const u8, "version", b.fmt("{f}", .{version})); + opts.addOption([]const u8, "version", version_string); + opts.addOption([]const u8, "version_encoded", version_encoded); opts.addOption(?[]const u8, "snapshot_path", snapshot_path); const enable_tsan = b.option(bool, "tsan", "Enable Thread Sanitizer") orelse false; diff --git a/src/crash_handler.zig b/src/crash_handler.zig index b6dd6b78..1706f990 100644 --- a/src/crash_handler.zig +++ b/src/crash_handler.zig @@ -86,7 +86,7 @@ fn report(reason: []const u8, begin_addr: usize, args: anytype) !void { var url_buffer: [4096]u8 = undefined; const url = blk: { var writer: std.Io.Writer = .fixed(&url_buffer); - try writer.print("https://crash.lightpanda.io/c?v={s}&r=", .{lp.build_config.version}); + try writer.print("https://crash.lightpanda.io/c?v={s}&r=", .{lp.build_config.version_encoded}); for (reason) |b| { switch (b) { 'A'...'Z', 'a'...'z', '0'...'9', '-', '.', '_' => try writer.writeByte(b),