From 4c8e2f20bf61bf1ff6e5ba3a16044e8a6ef5ff82 Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Tue, 29 Sep 2026 11:02:24 +0800 Subject: [PATCH] v8: update to latest stable release 15.5.35.13 Depends on https://github.com/lightpanda-io/zig-v8-fork/pull/215 and https://github.com/lightpanda-io/pkg/pull/3 --- .github/actions/install/action.yml | 2 +- Dockerfile | 2 +- build.zig.zon | 4 ++-- src/browser/js/Isolate.zig | 2 +- src/browser/js/Snapshot.zig | 1 + 5 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/actions/install/action.yml b/.github/actions/install/action.yml index 9b5d9eb05..238c68f8b 100644 --- a/.github/actions/install/action.yml +++ b/.github/actions/install/action.yml @@ -17,7 +17,7 @@ inputs: v8: description: 'v8 version to install' required: false - default: '14.9.207.35' + default: '15.5.35.13' cache-dir: description: 'cache dir to use' required: false diff --git a/Dockerfile b/Dockerfile index f62bd996c..9a15dfeb7 100644 --- a/Dockerfile +++ b/Dockerfile @@ -3,7 +3,7 @@ FROM debian:stable-slim ARG MINISIG=0.12 ARG ZIG_MINISIG=RWSGOq2NVecA2UPNdBUZykf1CCb147pkmdtYxgb3Ti+JO/wCYvhbAb/U -ARG V8=14.9.207.35 +ARG V8=15.5.35.13 ARG ZIG_V8=v0.5.7 ARG TARGETPLATFORM diff --git a/build.zig.zon b/build.zig.zon index ec4961626..f2f9658d0 100644 --- a/build.zig.zon +++ b/build.zig.zon @@ -5,8 +5,8 @@ .minimum_zig_version = "0.16.0", .dependencies = .{ .v8 = .{ - .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/ebd2fabfb001294ed43ef65286c7db17245416e9.tar.gz", - .hash = "v8-0.0.0-xddH66lEAwB-5Ec92QAp19-aZ6-oB8UnnUm-w3fBUEaX", + .url = "https://github.com/lightpanda-io/zig-v8-fork/archive/8bf03aa7259f3df9f2a107a2923fbd870c3d155d.tar.gz", + .hash = "v8-0.0.0-xddH63lIAwBNR7wjbA_m6ZQk4aWBDcjQSOTt3D0R6FnO", }, // .v8 = .{ .path = "../zig-v8-fork" }, .brotli = .{ diff --git a/src/browser/js/Isolate.zig b/src/browser/js/Isolate.zig index 3aa1ba32b..53809d5d4 100644 --- a/src/browser/js/Isolate.zig +++ b/src/browser/js/Isolate.zig @@ -58,7 +58,7 @@ pub fn adjustAmountOfExternalAllocatedMemory(self: Isolate, delta: i64) void { } pub fn notifyContextDisposed(self: Isolate) void { - _ = v8.v8__Isolate__ContextDisposedNotification(self.handle); + v8.v8__Isolate__ContextDisposedNotification(self.handle); } pub fn getHeapStatistics(self: Isolate) v8.HeapStatistics { diff --git a/src/browser/js/Snapshot.zig b/src/browser/js/Snapshot.zig index 93ba82da9..ccd6f0202 100644 --- a/src/browser/js/Snapshot.zig +++ b/src/browser/js/Snapshot.zig @@ -871,6 +871,7 @@ fn attachClass(comptime JsApi: type, comptime flatten: bool, isolate: *v8.Isolat .definer = if (value.definer) |definer| @ptrCast(definer) else null, .descriptor = null, .index_of = null, + .iterable_to_list = null, .data = null, .flags = 0, };