From 4dbec74dfcd18954b55fafad25489e2e18d8cb91 Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Sat, 13 Jun 2026 17:59:54 +0800 Subject: [PATCH] debug: Use normal crash report assertion in debug I don't know why I thought debug should `unreahcable` while release should generate a crash report. The crash report always contains more info and whenever I encounter a failed assertion in debug, the first thing I do is remove the unreachable to get the more complete crash report. (The crash report path skips sending the crash report in debug builds already) --- src/lightpanda.zig | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/lightpanda.zig b/src/lightpanda.zig index fb1659d4e..d7e735542 100644 --- a/src/lightpanda.zig +++ b/src/lightpanda.zig @@ -273,9 +273,6 @@ fn dumpWPT(frame: *Frame, writer: *std.Io.Writer) !void { pub inline fn assert(ok: bool, comptime ctx: []const u8, args: anytype) void { if (!ok) { - if (comptime IS_DEBUG) { - unreachable; - } assertionFailure(ctx, args); } }