From 708835b08b4999e8bfc57b622782bee5d5530ad4 Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Mon, 27 Jul 2026 18:49:40 +0800 Subject: [PATCH] crash: remove Target.sendMessageToTarget session_id assertion closeTarget above implies that the state this assertion guards against IS valid AND we just had a crash report confirming. That's enough for me to remove it. --- src/cdp/domains/target.zig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cdp/domains/target.zig b/src/cdp/domains/target.zig index e36c67339..703cd3d5f 100644 --- a/src/cdp/domains/target.zig +++ b/src/cdp/domains/target.zig @@ -366,8 +366,8 @@ fn sendMessageToTarget(cmd: *CDP.Command) !void { return error.TargetNotLoaded; } - lp.assert(bc.session_id != null, "CDP.target.sendMessageToTarget null session_id", .{}); - if (std.mem.eql(u8, bc.session_id.?, params.sessionId) == false) { + const session_id = bc.session_id orelse return error.UnknownSessionId; + if (std.mem.eql(u8, session_id, params.sessionId) == false) { // Is this right? Is the params.sessionId meant to be the active // sessionId? What else could it be? We have no other session_id. return error.UnknownSessionId;