From 8dc24888353011cee032f0d809086d22cfd02268 Mon Sep 17 00:00:00 2001
From: Muki Kiboigo <muki@muki.gg>
Date: Tue, 21 Jul 2026 08:40:54 -0700
Subject: [PATCH] always defer conn.rollback after tx begin

---
 src/network/cache/SqliteCache.zig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/network/cache/SqliteCache.zig b/src/network/cache/SqliteCache.zig
index 8992b9aba..a54da898d 100644
--- a/src/network/cache/SqliteCache.zig
+++ b/src/network/cache/SqliteCache.zig
@@ -127,7 +127,7 @@ pub fn get(self: *SqliteCache, arena: std.mem.Allocator, req: CacheRequest) !?Ca
     defer self.pool.release(conn);
 
     try conn.begin();
-    errdefer conn.rollback() catch {};
+    defer conn.rollback() catch {};
 
     var entry = try conn.row(
         \\ select status, stored_at, age_at_store,
@@ -253,7 +253,7 @@ pub fn put(self: *SqliteCache, meta: CachedMetadata, body: []const u8) !void {
     defer self.pool.release(conn);
 
     try conn.begin();
-    errdefer conn.rollback() catch {};
+    defer conn.rollback() catch {};
 
     try conn.exec("delete from metadata where url = $1", .{meta.url});
 
@@ -328,7 +328,7 @@ pub fn renew(self: *SqliteCache, _: std.mem.Allocator, req: RenewResponse) !void
     defer self.pool.release(conn);
 
     try conn.begin();
-    errdefer conn.rollback() catch {};
+    defer conn.rollback() catch {};
 
     const exists = try conn.row("select 1 from metadata where url = $1", .{req.url});
     if (exists) |*row| {