From bf775696de0eab08987f437f06ff19fdaa584a8b Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Fri, 17 Jul 2026 11:17:05 +0200 Subject: [PATCH] don't skip dispose dispatch when ondispose is unset --- src/browser/webapi/navigation/NavigationHistoryEntry.zig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/browser/webapi/navigation/NavigationHistoryEntry.zig b/src/browser/webapi/navigation/NavigationHistoryEntry.zig index 76beeb0bb..36aea19fb 100644 --- a/src/browser/webapi/navigation/NavigationHistoryEntry.zig +++ b/src/browser/webapi/navigation/NavigationHistoryEntry.zig @@ -82,10 +82,9 @@ pub fn getState(self: *const NavigationHistoryEntry, frame: *Frame) !StateReturn pub fn fireDispose(self: *NavigationHistoryEntry, frame: *Frame) !void { if (!frame.hasDirectListeners(self.asEventTarget(), "dispose", self._on_dispose)) return; - if (self._on_dispose == null) return; const event = try Event.initTrusted(comptime .wrap("dispose"), .{}, frame._page); - try frame.dispatch(self.asEventTarget(), event, self._on_dispose.?, .{ .context = "NavigationHistoryEntry" }); + try frame.dispatch(self.asEventTarget(), event, self._on_dispose, .{ .context = "NavigationHistoryEntry" }); } fn getOnDispose(self: *const NavigationHistoryEntry) ?js.Function.Global {