From ca08f0c56dc2dad363c742e2f67007c39bcf4888 Mon Sep 17 00:00:00 2001
From: Muki Kiboigo <muki@muki.gg>
Date: Sun, 26 Apr 2026 22:10:33 -0700
Subject: [PATCH] remove blocking from RequestParams

---
 src/browser/HttpClient.zig        | 7 -------
 src/browser/ScriptManager.zig     | 2 --
 src/network/layer/RobotsLayer.zig | 1 -
 3 files changed, 10 deletions(-)

diff --git a/src/browser/HttpClient.zig b/src/browser/HttpClient.zig
index 7600ad5a..db3b98b9 100644
--- a/src/browser/HttpClient.zig
+++ b/src/browser/HttpClient.zig
@@ -871,13 +871,6 @@ pub const RequestParams = struct {
     notification: *Notification,
     timeout_ms: u32 = 0,
 
-    // This is only relevant for intercepted requests. If a request is flagged
-    // as blocking AND is intercepted, then it'll be up to us to wait until
-    // we receive a response to the interception. This probably isn't ideal,
-    // but it's harder for our caller (ScriptManager) to deal with this. One
-    // reason for that is the Http Client is already a bit CDP-aware.
-    blocking: bool = false,
-
     const ResourceType = enum {
         document,
         xhr,
diff --git a/src/browser/ScriptManager.zig b/src/browser/ScriptManager.zig
index f707f390..12cc6cb5 100644
--- a/src/browser/ScriptManager.zig
+++ b/src/browser/ScriptManager.zig
@@ -292,7 +292,6 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
                 .frame_id = frame._frame_id,
                 .loader_id = frame._loader_id,
                 .headers = headers,
-                .blocking = true,
                 .cookie_jar = &frame._session.cookie_jar,
                 .cookie_origin = frame.url,
                 .resource_type = .script,
@@ -316,7 +315,6 @@ pub fn addFromElement(self: *ScriptManager, comptime from_parser: bool, script_e
                     .frame_id = frame._frame_id,
                     .loader_id = frame._loader_id,
                     .headers = headers,
-                    .blocking = false,
                     .cookie_jar = &frame._session.cookie_jar,
                     .cookie_origin = frame.url,
                     .resource_type = .script,
diff --git a/src/network/layer/RobotsLayer.zig b/src/network/layer/RobotsLayer.zig
index eb38b720..aa3d0e5f 100644
--- a/src/network/layer/RobotsLayer.zig
+++ b/src/network/layer/RobotsLayer.zig
@@ -114,7 +114,6 @@ fn fetchRobotsThenRequest(
                 .url = robots_url,
                 .method = .GET,
                 .headers = headers,
-                .blocking = false,
                 .frame_id = req.params.frame_id,
                 .loader_id = req.params.loader_id,
                 .cookie_jar = req.params.cookie_jar,