From ce5f6195db0ec24a591665e340b0a75d1c8bc6e8 Mon Sep 17 00:00:00 2001 From: Celine Debled Date: Tue, 22 Sep 2026 12:28:37 +0200 Subject: [PATCH] cdp: test that replies echo the sessionId --- src/server/cdp/domains/browser.zig | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/server/cdp/domains/browser.zig b/src/server/cdp/domains/browser.zig index 1cf61c269..87d899e29 100644 --- a/src/server/cdp/domains/browser.zig +++ b/src/server/cdp/domains/browser.zig @@ -249,6 +249,16 @@ test "cdp.browser: getVersion" { }, .{ .id = 32, .index = 0, .session_id = null }); } +// Clients route replies by (sessionId, id): a reply must echo the sessionId of its command. +test "cdp.browser: replies echo the sessionId" { + var ctx = try testing.context(); + defer ctx.deinit(); + + _ = try ctx.loadBrowserContext(.{ .session_id = "SID-X" }); + try ctx.processMessage(.{ .id = 1, .method = "Browser.getVersion", .sessionId = "SID-X" }); + try ctx.expectSentResult(.{ .product = PRODUCT }, .{ .id = 1, .session_id = "SID-X" }); +} + test "cdp.browser: getWindowForTarget" { var ctx = try testing.context(); defer ctx.deinit();