From 723b961be741165ebe74784d51005478448f2524 Mon Sep 17 00:00:00 2001 From: Karl Seguin Date: Thu, 18 Jun 2026 15:43:37 +0800 Subject: [PATCH] tests: remove external connection from unit tests A unit test was hitting http://example.com/. As far as I can tell, there was no good reason for this. Replaced it with hitting the local test server and the test continues to pass. Three reasons to avoid hitting an external resource in a unit test: 1 - it can be slow 2 - if it's flaky, it's outside our control 3 - since every zig build test generates a new binary, my firewall warns me about a new outgoing connection every test --- src/mcp/tools.zig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mcp/tools.zig b/src/mcp/tools.zig index f84ffe86d..d7f2cacf1 100644 --- a/src/mcp/tools.zig +++ b/src/mcp/tools.zig @@ -1287,10 +1287,10 @@ test "MCP - press Enter on form input triggers submit (lowercase alias)" { test "MCP - getCookies: defaults to current page, url filter, all flag" { defer testing.reset(); var out: std.io.Writer.Allocating = .init(testing.arena_allocator); - const server = try testLoadPage("http://example.com/", &out.writer); + const server = try testLoadPage("http://localhost:9582/src/browser/tests/mcp_press_form.htm", &out.writer); defer server.deinit(); - try server.session.cookie_jar.populateFromResponse("http://example.com/", "session=abc; Path=/"); + try server.session.cookie_jar.populateFromResponse("http://localhost:9582", "session=abc; Path=/"); try server.session.cookie_jar.populateFromResponse("http://other.test/", "tracking=xyz; Path=/"); const default_msg =