From ffd293a18e1a35708dd5c8c549fb25a37fefc2bc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A0=20Arrufat?= Date: Wed, 5 Aug 2026 08:59:28 +0200 Subject: [PATCH] goto: warn against 'done' in the waitUntil description Review feedback: 'done' sounds like what people want and is the slowest option. Same treatment as waitForState's description. --- src/browser/tools.zig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/browser/tools.zig b/src/browser/tools.zig index 40bccb395..250a53788 100644 --- a/src/browser/tools.zig +++ b/src/browser/tools.zig @@ -342,7 +342,7 @@ pub const Tool = enum { \\ "timeout": { "type": "integer", "description": "Optional timeout in milliseconds. Defaults to 10000." }, \\ "waitUntil": { "type": "string", "enum": ++ lp.Config.tagJsonArray(lp.Config.WaitUntil) ++ - \\, "description": "Event that completes the navigation. Defaults to 'load'. Prefer 'domcontentloaded' followed by waitForSelector on pages whose late scripts (ads) hold 'load' back." } + \\, "description": "Event that completes the navigation. Defaults to 'load'. Prefer 'domcontentloaded' followed by waitForSelector on pages whose late scripts (ads) hold 'load' back. Avoid 'done' (full quiescence): on pages with constant background activity it is the slowest choice and can run to the timeout." } \\ }, \\ "required": ["url"] \\}