mirror of
https://github.com/lightpanda-io/browser.git
synced 2026-06-11 01:25:53 -04:00
79cdbd285d
Depends on https://github.com/lightpanda-io/zig-v8-fork/pull/179 An improvement to https://github.com/lightpanda-io/browser/pull/2515 to prevent a v8 assertion if we terminate as an inspector dispatch is happening. The problem is that if we just immediately terminate, we aren't sure what the worker thread is doing, and, apparently, if we terminate then dispatch a message to the inspector, we fail an assertion. With the way the code was, the only safe solution would be to hold a mutex over the session dispatch, but that could block the network thread. So instead of terminating from the network thread, we now ask v8 to execute a callback. This gets executed on the worker thread, which can then terminate the execution. The initial version of 2515 delayed the termination from the network thread. It's possible that solution would "solve" the issue, simply because it's very unlikely that a worker would be "stuck" for 5 seconds and then get unstuck. More likely that it exits immediately, or is stuck in an endless loop. But that would still leave a window where we could terminate in network and then dispatch in the worker. Less likely, but still possible. Hopefully this new mechanism eliminates this from being a problem in all circumstances.