mirror of
https://github.com/lightpanda-io/browser.git
synced 2026-09-17 00:17:07 -04:00
Built against https://github.com/lightpanda-io/zig-v8-fork/tree/zig-0.16 but it doesn't require a new v8 build. Built against https://github.com/lightpanda-io/boringssl-zig/tree/zig-0.16 since the current fork we point to isn't updated. A global std.Io instance, lp.io. Way easier this way and requires 0 changes to our libcurl integration / event loop. Network code uses a new layer that does what Zig 0.15's posix package used to do. Again, quicker migration that way. But, as long as we have the global IO, and given the half-baked nature of networking in std.Io 0.16, this just makes sense. Things can be migrated as needed. The std.time.* -> std.Io.Timestamp/Clock/Duration resulted in _a lot_ of changes. ArrayList = .{} -> ArrayList -> .empty also resulted in a lot of changes, but that's obviously superficial. As is the trimLeft/trimRight -> trimStart/trimEnd rename. Locking adopt the `Uncancelable` variants, e.g. mutex.lockUncancelable() to preserve the error-free signature (and, because cancellation would be something we'd have to put more thought into). std.json.ObjectMap is now unmanaged, so the allocator had to be passed along. However, there's still a deprecated managed variant of MemoryPool, so I switched to it (we can do a small follow up PR to move to the unmanaged after). I tried use_llvm = false, but it locks my computer, consuming RAM until MacOS gives me a popup I've never seen before, begging me to start killing processes. Agent and the networking stuff saw the most significant changes.
169 lines
5.1 KiB
Zig
169 lines
5.1 KiB
Zig
// Copyright (C) 2023-2026 Lightpanda (Selecy SAS)
|
|
//
|
|
// Francis Bouvier <francis@lightpanda.io>
|
|
// Pierre Tachoire <pierre@lightpanda.io>
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as
|
|
// published by the Free Software Foundation, either version 3 of the
|
|
// License, or (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <https://www.gnu.org/licenses/>.
|
|
|
|
const std = @import("std");
|
|
const lp = @import("lightpanda");
|
|
const Sqlite = @import("Sqlite.zig");
|
|
|
|
const Thread = std.Thread;
|
|
const Allocator = std.mem.Allocator;
|
|
|
|
const Pool = @This();
|
|
|
|
available: usize,
|
|
mutex: std.Io.Mutex,
|
|
cond: std.Io.Condition,
|
|
conns: []Sqlite.Conn,
|
|
|
|
pub fn init(allocator: Allocator, path: [:0]const u8) !Pool {
|
|
// can't have a pool of connections to in-memory database, so, to keep the
|
|
// API simple, we create a pool of 1.
|
|
const count: usize = if (std.mem.eql(u8, path, ":memory:")) 1 else 5;
|
|
|
|
var conns = try allocator.alloc(Sqlite.Conn, count);
|
|
errdefer allocator.free(conns);
|
|
|
|
var initialized: usize = 0;
|
|
errdefer {
|
|
for (0..initialized) |i| {
|
|
conns[i].close();
|
|
}
|
|
}
|
|
|
|
for (0..count) |i| {
|
|
conns[i] = try Sqlite.Conn.open(path);
|
|
initialized += 1;
|
|
try conns[i].busyTimeout(1000);
|
|
}
|
|
|
|
return .{
|
|
.cond = .init,
|
|
.mutex = .init,
|
|
.conns = conns,
|
|
.available = count,
|
|
};
|
|
}
|
|
|
|
pub fn deinit(self: *Pool, allocator: Allocator) void {
|
|
for (self.conns) |conn| {
|
|
conn.close();
|
|
}
|
|
allocator.free(self.conns);
|
|
}
|
|
|
|
pub fn acquire(self: *Pool) !Sqlite.Conn {
|
|
const conns = self.conns;
|
|
|
|
self.mutex.lockUncancelable(lp.io);
|
|
while (true) {
|
|
const available = self.available;
|
|
if (available == 0) {
|
|
// @ZIG16 Io.Condition has no timedWait; restore the 5s
|
|
// starvation bail-out when one lands.
|
|
self.cond.waitUncancelable(lp.io, &self.mutex);
|
|
continue;
|
|
}
|
|
const index = available - 1;
|
|
const conn = conns[index];
|
|
self.available = index;
|
|
self.mutex.unlock(lp.io);
|
|
return conn;
|
|
}
|
|
}
|
|
|
|
pub fn release(self: *Pool, conn: Sqlite.Conn) void {
|
|
var conns = self.conns;
|
|
|
|
self.mutex.lockUncancelable(lp.io);
|
|
const available = self.available;
|
|
conns[available] = conn;
|
|
self.available = available + 1;
|
|
self.mutex.unlock(lp.io);
|
|
self.cond.signal(lp.io);
|
|
}
|
|
|
|
const testing = @import("../../testing.zig");
|
|
test "Sqlite: Pool" {
|
|
// :memory: _has_ to run with a single connection in the pool, which isn't
|
|
// that useful for testing. So we create a temp file.
|
|
|
|
std.Io.Dir.cwd().deleteFile(testing.io, "/tmp/lightpanda_test.sqlite") catch {};
|
|
var pool = try Pool.init(testing.allocator, "/tmp/lightpanda_test.sqlite");
|
|
|
|
defer {
|
|
pool.deinit(testing.allocator);
|
|
std.Io.Dir.cwd().deleteFile(testing.io, "/tmp/lightpanda_test.sqlite") catch {};
|
|
}
|
|
|
|
{
|
|
const conn = try pool.acquire();
|
|
defer pool.release(conn);
|
|
|
|
try conn.exec("create table pool_test (cnt int not null)", .{});
|
|
try conn.exec("insert into pool_test (cnt) values (0)", .{});
|
|
}
|
|
|
|
for (pool.conns) |conn| {
|
|
// This is not safe and can result in corruption. This is only set
|
|
// because the tests might be run on really slow hardware and we
|
|
// want to avoid having a busy timeout.
|
|
try conn.exec("pragma synchronous=off", .{});
|
|
|
|
// Also not safe, but we're trying to avoid busy timeouts without using
|
|
// WAL mode, which can trigger false positives in thread-sanitizer
|
|
try conn.exec("pragma journal_mode=memory", .{});
|
|
}
|
|
|
|
const t1 = try Thread.spawn(.{}, testPool, .{&pool});
|
|
const t2 = try Thread.spawn(.{}, testPool, .{&pool});
|
|
const t3 = try Thread.spawn(.{}, testPool, .{&pool});
|
|
const t4 = try Thread.spawn(.{}, testPool, .{&pool});
|
|
const t5 = try Thread.spawn(.{}, testPool, .{&pool});
|
|
const t6 = try Thread.spawn(.{}, testPool, .{&pool});
|
|
|
|
t1.join();
|
|
t2.join();
|
|
t3.join();
|
|
t4.join();
|
|
t5.join();
|
|
t6.join();
|
|
|
|
const c1 = try pool.acquire();
|
|
defer pool.release(c1);
|
|
|
|
const row = (try c1.row("select cnt from pool_test", .{})).?;
|
|
try testing.expectEqual(600, row.get(i64, 0));
|
|
row.deinit();
|
|
|
|
try c1.exec("drop table pool_test", .{});
|
|
}
|
|
|
|
fn testPool(p: *Pool) !void {
|
|
for (0..100) |_| {
|
|
const conn = try p.acquire();
|
|
conn.exec("begin immediate", .{}) catch unreachable;
|
|
conn.exec("update pool_test set cnt = cnt + 1", .{}) catch |err| {
|
|
std.debug.print("update err: {any}\n", .{err});
|
|
unreachable;
|
|
};
|
|
conn.exec("commit", .{}) catch unreachable;
|
|
p.release(conn);
|
|
lp.io.sleep(.fromMilliseconds(2), .awake) catch {};
|
|
}
|
|
}
|