mirror/cryptomator
1
0
Fork 0
mirror of https://github.com/cryptomator/cryptomator.git synced 2026-04-21 10:06:55 -04:00
Code Issues Packages Projects Releases Wiki Activity

Applied suggestions from code review

Browse Source 
Changed signature of afterExecuteTask
See: https://github.com/cryptomator/cryptomator/pull/2259/files#r875548549

--

Changed name of "afterExecute0" to "afterExecuteInternal"
See: https://github.com/cryptomator/cryptomator/pull/2259/files#r875551994
This commit is contained in:
JaniruTEC
2022-05-27 01:23:06 +02:00
parent e9a71827ed
commit f740a93b6c
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/main/java/org/cryptomator/common/CatchingExecutors.java
View File

@@ -31,7 +31,7 @@ public final class CatchingExecutors {
@Override
protected void afterExecute(Runnable runnable, Throwable throwable) {
super.afterExecute(runnable, throwable);
afterExecute0(runnable, throwable);
afterExecuteInternal(runnable, throwable);
}
}
@@ -44,15 +44,15 @@ public final class CatchingExecutors {
@Override
protected void afterExecute(Runnable runnable, Throwable throwable) {
super.afterExecute(runnable, throwable);
afterExecute0(runnable, throwable);
afterExecuteInternal(runnable, throwable);
}
}
private static void afterExecute0(Runnable runnable, Throwable throwable) {
private static void afterExecuteInternal(Runnable runnable, Throwable throwable) {
if (throwable != null) {
callHandler(Thread.currentThread(), throwable);
} else if (runnable instanceof Task<?> t) {
afterExecuteTask(Thread.currentThread(), t);
afterExecuteTask(t);
} else if (runnable instanceof Future<?> f) {
afterExecuteFuture(f);
}
@@ -67,7 +67,8 @@ public final class CatchingExecutors {
return (thread, throwable) -> LOG.error("FALLBACK: Uncaught exception in " + thread.getName(), throwable);
}
private static void afterExecuteTask(Thread caller, Task<?> task) {
private static void afterExecuteTask(Task<?> task) {
var caller = Thread.currentThread();
Platform.runLater(() -> {
if (task.getOnFailed() == null) {
callHandler(caller, task.getException());