mirror of
https://github.com/fastapi/fastapi.git
synced 2026-01-26 06:51:40 -05:00
a4aa79e0b4
* ♻️ Refactor dependency AsyncExitStack logic, exit dependencies after creating the response, before sending it * ✅ Update tests for dependencies exit, check they are finished before the response is sent * 🔥 Remove ExitAsyncStackMiddleware as it's no longer needed * 📝 Update docs for dependencies with yield * 📝 Update release notes * 📝 Add source examples for new dependencies with yield raising * ✅ Add tests for new dependencies raising after yield * 📝 Update release notes
40 lines
1.4 KiB
Python
40 lines
1.4 KiB
Python
from contextlib import asynccontextmanager as asynccontextmanager
|
|
from typing import AsyncGenerator, ContextManager, TypeVar
|
|
|
|
import anyio
|
|
from anyio import CapacityLimiter
|
|
from starlette.concurrency import iterate_in_threadpool as iterate_in_threadpool # noqa
|
|
from starlette.concurrency import run_in_threadpool as run_in_threadpool # noqa
|
|
from starlette.concurrency import ( # noqa
|
|
run_until_first_complete as run_until_first_complete,
|
|
)
|
|
|
|
_T = TypeVar("_T")
|
|
|
|
|
|
@asynccontextmanager
|
|
async def contextmanager_in_threadpool(
|
|
cm: ContextManager[_T],
|
|
) -> AsyncGenerator[_T, None]:
|
|
# blocking __exit__ from running waiting on a free thread
|
|
# can create race conditions/deadlocks if the context manager itself
|
|
# has its own internal pool (e.g. a database connection pool)
|
|
# to avoid this we let __exit__ run without a capacity limit
|
|
# since we're creating a new limiter for each call, any non-zero limit
|
|
# works (1 is arbitrary)
|
|
exit_limiter = CapacityLimiter(1)
|
|
try:
|
|
yield await run_in_threadpool(cm.__enter__)
|
|
except Exception as e:
|
|
ok = bool(
|
|
await anyio.to_thread.run_sync(
|
|
cm.__exit__, type(e), e, None, limiter=exit_limiter
|
|
)
|
|
)
|
|
if not ok:
|
|
raise e
|
|
else:
|
|
await anyio.to_thread.run_sync(
|
|
cm.__exit__, None, None, None, limiter=exit_limiter
|
|
)
|