From 08e1d04b7ad6509cb0a9c7e2f2e9e00f3d821710 Mon Sep 17 00:00:00 2001
From: Torsten Grote <t@grobox.de>
Date: Fri, 24 Oct 2025 16:36:00 -0300
Subject: [PATCH] Fix featureGraphic jumping after loading error

---
 .../kotlin/org/fdroid/ui/details/AppDetailsHeader.kt     | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/next/src/main/kotlin/org/fdroid/ui/details/AppDetailsHeader.kt b/next/src/main/kotlin/org/fdroid/ui/details/AppDetailsHeader.kt
index ecc1cb14c..8198f5c98 100644
--- a/next/src/main/kotlin/org/fdroid/ui/details/AppDetailsHeader.kt
+++ b/next/src/main/kotlin/org/fdroid/ui/details/AppDetailsHeader.kt
@@ -16,7 +16,6 @@ import androidx.compose.foundation.layout.size
 import androidx.compose.foundation.text.selection.SelectionContainer
 import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.filled.Cancel
-import androidx.compose.material.icons.filled.Error
 import androidx.compose.material3.Button
 import androidx.compose.material3.CircularProgressIndicator
 import androidx.compose.material3.ExperimentalMaterial3ExpressiveApi
@@ -35,7 +34,6 @@ import androidx.compose.runtime.remember
 import androidx.compose.runtime.rememberUpdatedState
 import androidx.compose.runtime.saveable.rememberSaveable
 import androidx.compose.runtime.setValue
-import androidx.compose.ui.Alignment
 import androidx.compose.ui.Alignment.Companion.CenterHorizontally
 import androidx.compose.ui.Alignment.Companion.CenterVertically
 import androidx.compose.ui.Modifier
@@ -44,7 +42,6 @@ import androidx.compose.ui.graphics.BlendMode
 import androidx.compose.ui.graphics.Brush
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.graphics.graphicsLayer
-import androidx.compose.ui.graphics.vector.rememberVectorPainter
 import androidx.compose.ui.layout.ContentScale
 import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.res.painterResource
@@ -81,6 +78,9 @@ fun AppDetailsHeader(
             onSuccess = {
                 showTopSpacer = false
             },
+            onError = {
+                showTopSpacer = true
+            },
             modifier = Modifier
                 .fillMaxWidth()
                 .heightIn(max = 196.dp)
@@ -97,7 +97,6 @@ fun AppDetailsHeader(
                     )
                 }
                 .padding(bottom = 8.dp),
-            error = rememberVectorPainter(Icons.Default.Error),
         )
     }
     // Header
@@ -105,7 +104,7 @@ fun AppDetailsHeader(
         modifier = Modifier
             .padding(horizontal = 16.dp),
         horizontalArrangement = spacedBy(8.dp),
-        verticalAlignment = Alignment.CenterVertically,
+        verticalAlignment = CenterVertically,
     ) {
         AsyncShimmerImage(
             model = item.icon,