From 415fd0c59dbe088fa0f5c492fbc6ce04d5b55067 Mon Sep 17 00:00:00 2001
From: Torsten Grote <t@grobox.de>
Date: Fri, 24 Mar 2023 13:11:50 -0300
Subject: [PATCH] Revert "[app] Disable auto-download of APKs because basic
 can't do it yet due to recent targetSdk"

This reverts commit f8a0c1c44844e1b85c3baf1d5d42c87626e79d55.
---
 app/src/basic/res/xml/preferences.xml                          | 2 --
 app/src/main/java/org/fdroid/fdroid/Preferences.java           | 3 +--
 .../main/java/org/fdroid/fdroid/views/PreferencesFragment.java | 3 +--
 3 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/app/src/basic/res/xml/preferences.xml b/app/src/basic/res/xml/preferences.xml
index 3693bfb24..3f0e10c66 100644
--- a/app/src/basic/res/xml/preferences.xml
+++ b/app/src/basic/res/xml/preferences.xml
@@ -42,12 +42,10 @@
                 android:title="@string/over_data"
                 android:defaultValue="@integer/defaultOverData"
                 android:layout="@layout/preference_seekbar"/>
-        <!-- TODO re-enable once basic can do auto-downloads
         <SwitchPreferenceCompat
                 android:title="@string/update_auto_download"
                 android:summary="@string/update_auto_download_summary"
                 android:key="updateAutoDownload"/>
-        -->
         <org.fdroid.fdroid.views.LiveSeekBarPreference
                 android:key="updateIntervalSeekBarPosition"
                 android:title="@string/update_interval"
diff --git a/app/src/main/java/org/fdroid/fdroid/Preferences.java b/app/src/main/java/org/fdroid/fdroid/Preferences.java
index 4ec8750df..36e4300a3 100644
--- a/app/src/main/java/org/fdroid/fdroid/Preferences.java
+++ b/app/src/main/java/org/fdroid/fdroid/Preferences.java
@@ -432,8 +432,7 @@ public final class Preferences implements SharedPreferences.OnSharedPreferenceCh
     }
 
     public boolean isAutoDownloadEnabled() {
-        return !"basic".equals(BuildConfig.FLAVOR) // TODO remove once basic can do auto-downloads
-                && preferences.getBoolean(PREF_AUTO_DOWNLOAD_INSTALL_UPDATES, IGNORED_B);
+        return preferences.getBoolean(PREF_AUTO_DOWNLOAD_INSTALL_UPDATES, IGNORED_B);
     }
 
     /**
diff --git a/app/src/main/java/org/fdroid/fdroid/views/PreferencesFragment.java b/app/src/main/java/org/fdroid/fdroid/views/PreferencesFragment.java
index 8715c42a6..deefdb156 100644
--- a/app/src/main/java/org/fdroid/fdroid/views/PreferencesFragment.java
+++ b/app/src/main/java/org/fdroid/fdroid/views/PreferencesFragment.java
@@ -43,7 +43,6 @@ import com.bumptech.glide.RequestManager;
 import com.bumptech.glide.request.RequestOptions;
 import com.google.android.material.dialog.MaterialAlertDialogBuilder;
 
-import org.fdroid.fdroid.BuildConfig;
 import org.fdroid.fdroid.FDroidApp;
 import org.fdroid.fdroid.Languages;
 import org.fdroid.fdroid.Preferences;
@@ -565,7 +564,7 @@ public class PreferencesFragment extends PreferenceFragmentCompat
 
         currentKeepCacheTime = Preferences.get().getKeepCacheTime();
 
-        if (!"basic".equals(BuildConfig.FLAVOR)) initAutoFetchUpdatesPreference(); // TODO remove once basic can do it
+        initAutoFetchUpdatesPreference();
         initPrivilegedInstallerPreference();
         initUseTorPreference(getActivity().getApplicationContext());
     }