mirror/fdroidclient
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidclient.git synced 2026-06-18 12:49:59 -04:00
Code Issues Packages Projects Releases Wiki Activity

only prompt to swap back to proper swap URLs

Browse Source 
Before, it was possible to annoy the user by sending HTTP POST with any
repo URL in it.
This commit is contained in:
Hans-Christoph Steiner
2018-04-13 00:20:52 +02:00
parent f181e41338
commit 615e559ce1
5 changed files with 73 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
app/src/test/java/org/fdroid/fdroid/net/HttpDownloaderTest.java Normal file
View File

@@ -0,0 +1,36 @@
package org.fdroid.fdroid.net;
import android.net.Uri;
import org.apache.commons.net.util.SubnetUtils;
import org.fdroid.fdroid.BuildConfig;
import org.fdroid.fdroid.FDroidApp;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.robolectric.RobolectricTestRunner;
import org.robolectric.annotation.Config;
import java.net.MalformedURLException;
import java.net.URL;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertFalse;
@Config(constants = BuildConfig.class, sdk = 24)
@RunWith(RobolectricTestRunner.class)
@SuppressWarnings("LineLength")
public class HttpDownloaderTest {
@Test
public void testIsSwapUri() throws MalformedURLException {
FDroidApp.subnetInfo = new SubnetUtils("192.168.0.112/24").getInfo();
String urlString = "http://192.168.0.112:8888/fdroid/repo?fingerprint=113F56CBFA967BA825DD13685A06E35730E0061C6BB046DF88A";
assertTrue(HttpDownloader.isSwapUrl("192.168.0.112", 8888)); // NOPMD
assertTrue(HttpDownloader.isSwapUrl(Uri.parse(urlString)));
assertTrue(HttpDownloader.isSwapUrl(new URL(urlString)));
assertFalse(HttpDownloader.isSwapUrl("192.168.1.112", 8888)); // NOPMD
assertFalse(HttpDownloader.isSwapUrl("192.168.0.112", 80)); // NOPMD
assertFalse(HttpDownloader.isSwapUrl(Uri.parse("https://malware.com:8888")));
assertFalse(HttpDownloader.isSwapUrl(new URL("https://www.google.com")));
}
}