mirror/fdroidclient
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidclient.git synced 2026-02-05 04:32:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

move SanitizedFileTest into non-Android tests

Browse Source 
It can run in plain java, so might as well.
This commit is contained in:
Hans-Christoph Steiner
2016-03-22 21:02:24 +01:00
parent bc3d8a89b6
commit 74274d21b4
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
app/src/androidTest/java/org/fdroid/fdroid/SanitizedFileTest.java
View File

@@ -1,46 +0,0 @@
package org.fdroid.fdroid;
import android.test.AndroidTestCase;
import org.fdroid.fdroid.data.SanitizedFile;
import java.io.File;
@SuppressWarnings("PMD") // TODO port this to JUnit 4 semantics
public class SanitizedFileTest extends AndroidTestCase {
public void testSanitizedFile() {
File directory = new File("/tmp/blah");
String safeFile = "safe";
String nonEvilFile = "$%^safe-and_bleh.boo*@~";
String evilFile = ";rm /etc/shadow;";
File safeNotSanitized = new File(directory, safeFile);
File nonEvilNotSanitized = new File(directory, nonEvilFile);
File evilNotSanitized = new File(directory, evilFile);
assertEquals("/tmp/blah/safe", safeNotSanitized.getAbsolutePath());
assertEquals("/tmp/blah/$%^safe-and_bleh.boo*@~", nonEvilNotSanitized.getAbsolutePath());
assertEquals("/tmp/blah/;rm /etc/shadow;", evilNotSanitized.getAbsolutePath());
assertEquals("safe", safeNotSanitized.getName());
assertEquals("$%^safe-and_bleh.boo*@~", nonEvilNotSanitized.getName());
assertEquals("shadow;", evilNotSanitized.getName()); // Should be ;rm /etc/shadow; but the forward slashes are naughty.
SanitizedFile safeSanitized = new SanitizedFile(directory, safeFile);
SanitizedFile nonEvilSanitized = new SanitizedFile(directory, nonEvilFile);
SanitizedFile evilSanitized = new SanitizedFile(directory, evilFile);
assertEquals("/tmp/blah/safe", safeSanitized.getAbsolutePath());
assertEquals("/tmp/blah/safe-and_bleh.boo", nonEvilSanitized.getAbsolutePath());
assertEquals("/tmp/blah/rmetcshadow", evilSanitized.getAbsolutePath());
assertEquals("safe", safeSanitized.getName());
assertEquals("safe-and_bleh.boo", nonEvilSanitized.getName());
assertEquals("rmetcshadow", evilSanitized.getName());
}
}