mirror/fdroidclient
1
0
Fork 0
mirror of https://github.com/f-droid/fdroidclient.git synced 2026-04-21 07:18:05 -04:00
Code Issues Packages Projects Releases Wiki Activity

[db] Handle users with a thousand apps or more installed in AppDao

Browse Source
This commit is contained in:
Torsten Grote
2023-01-02 16:52:27 -03:00
committed by Hans-Christoph Steiner
parent a474198c34
commit 7a2d0e31f3
2 changed files with 78 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
libs/database/src/dbTest/java/org/fdroid/database/AppListItemsTest.kt
View File

@@ -20,6 +20,7 @@ import kotlin.random.Random
import kotlin.test.assertEquals
import kotlin.test.assertFalse
import kotlin.test.assertNotEquals
import kotlin.test.assertNotNull
import kotlin.test.assertNull
import kotlin.test.assertTrue
import kotlin.test.fail
@@ -426,6 +427,45 @@ internal class AppListItemsTest : AppTest() {
}
}
@Test
fun testGetInstalledAppListItemsMaxVars() {
// insert an app
val repoId = repoDao.insertOrReplace(getRandomRepo())
appDao.insert(repoId, packageName, app1, locales)
val packageInfoCreator = { name: String ->
@Suppress("DEPRECATION")
PackageInfo().apply {
packageName = name
versionName = name
versionCode = Random.nextInt(1, Int.MAX_VALUE)
}
}
val packageInfo = packageInfoCreator(packageName)
// sqlite has a maximum number of 999 variables that can be used in a query
val listPackageInfo = listOf(packageInfo)
val packageInfoOk = MutableList(999) { packageInfoCreator(getRandomString()) }
val packageInfoNotOk1 = MutableList(1000) { packageInfoCreator(getRandomString()) }
val packageInfoNotOk2 = MutableList(5000) { packageInfoCreator(getRandomString()) }
// app gets returned no matter how many packages are installed
every { pm.getInstalledPackages(0) } returns packageInfoOk + listPackageInfo
assertEquals(1, appDao.getInstalledAppListItems(pm).getOrFail().size)
every { pm.getInstalledPackages(0) } returns packageInfoNotOk1 + listPackageInfo
assertEquals(1, appDao.getInstalledAppListItems(pm).getOrFail().size)
every { pm.getInstalledPackages(0) } returns packageInfoNotOk2 + listPackageInfo
assertEquals(1, appDao.getInstalledAppListItems(pm).getOrFail().size)
// ensure they have version info set
every { pm.getInstalledPackages(0) } returns packageInfoOk + listPackageInfo
assertNotNull(appDao.getInstalledAppListItems(pm).getOrFail()[0].installedVersionName)
every { pm.getInstalledPackages(0) } returns packageInfoNotOk1 + listPackageInfo
assertNotNull(appDao.getInstalledAppListItems(pm).getOrFail()[0].installedVersionName)
every { pm.getInstalledPackages(0) } returns packageInfoNotOk2 + listPackageInfo
assertNotNull(appDao.getInstalledAppListItems(pm).getOrFail()[0].installedVersionName)
}
/**
* Runs the given block on all getAppListItems* methods.
* Uses category "A" as all apps should be in that.