From 7c9083fea15c87904058222eef11d0752dcc1443 Mon Sep 17 00:00:00 2001
From: Torsten Grote <t@grobox.de>
Date: Tue, 10 Oct 2023 11:08:10 -0300
Subject: [PATCH] Add test for compat flag in AppOverviewItems

---
 .../fdroid/database/AppOverviewItemsTest.kt   | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/libs/database/src/dbTest/java/org/fdroid/database/AppOverviewItemsTest.kt b/libs/database/src/dbTest/java/org/fdroid/database/AppOverviewItemsTest.kt
index a13a005d3..ad7aa0c72 100644
--- a/libs/database/src/dbTest/java/org/fdroid/database/AppOverviewItemsTest.kt
+++ b/libs/database/src/dbTest/java/org/fdroid/database/AppOverviewItemsTest.kt
@@ -10,8 +10,10 @@ import org.fdroid.test.TestVersionUtils.getRandomPackageVersionV2
 import org.junit.Test
 import org.junit.runner.RunWith
 import kotlin.test.assertEquals
+import kotlin.test.assertFalse
 import kotlin.test.assertNotNull
 import kotlin.test.assertNull
+import kotlin.test.assertTrue
 
 @RunWith(AndroidJUnit4::class)
 internal class AppOverviewItemsTest : AppTest() {
@@ -89,6 +91,50 @@ internal class AppOverviewItemsTest : AppTest() {
         assertEquals(3, appDao.getAppOverviewItems(42).getOrFail().size)
     }
 
+    @Test
+    fun testIncompatibleFlag() {
+        // insert two apps
+        val repoId = repoDao.insertOrReplace(getRandomRepo())
+        appDao.insert(repoId, packageName1, app1, locales)
+        appDao.insert(repoId, packageName2, app2, locales)
+
+        // both apps are not compatible
+        appDao.getAppOverviewItems().getOrFail().also {
+            assertEquals(2, it.size)
+        }.forEach {
+            assertFalse(it.isCompatible)
+        }
+        // both apps, in the same category, are not compatible
+        appDao.getAppOverviewItems("A").getOrFail().also {
+            assertEquals(2, it.size)
+        }.forEach {
+            assertFalse(it.isCompatible)
+        }
+        assertFalse(appDao.getAppOverviewItem(repoId, packageName1)!!.isCompatible)
+        assertFalse(appDao.getAppOverviewItem(repoId, packageName2)!!.isCompatible)
+
+        // each app gets a version
+        versionDao.insert(repoId, packageName1, "1", getRandomPackageVersionV2(), true)
+        versionDao.insert(repoId, packageName2, "1", getRandomPackageVersionV2(), false)
+
+        // updating compatibility for apps
+        appDao.updateCompatibility(repoId)
+
+        // now only one is not compatible
+        appDao.getAppOverviewItems().getOrFail().also {
+            assertEquals(2, it.size)
+            assertFalse(it[0].isCompatible)
+            assertTrue(it[1].isCompatible)
+        }
+        appDao.getAppOverviewItems("A").getOrFail().also {
+            assertEquals(2, it.size)
+            assertFalse(it[0].isCompatible)
+            assertTrue(it[1].isCompatible)
+        }
+        assertTrue(appDao.getAppOverviewItem(repoId, packageName1)!!.isCompatible)
+        assertFalse(appDao.getAppOverviewItem(repoId, packageName2)!!.isCompatible)
+    }
+
     @Test
     fun testGetByRepoWeight() {
         // insert one app with one version