From 91bbfd4cf0056818deebe583b51873486934403c Mon Sep 17 00:00:00 2001 From: Torsten Grote Date: Wed, 31 May 2023 17:41:45 -0300 Subject: [PATCH] [app] don't show repeated unknown sources screen when installing apps by limiting the use of PackageManager#canRequestPackageInstalls() method to flavors targeting at least O --- .../java/org/fdroid/fdroid/installer/DefaultInstaller.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/main/java/org/fdroid/fdroid/installer/DefaultInstaller.java b/app/src/main/java/org/fdroid/fdroid/installer/DefaultInstaller.java index 7a1bb65ef..b7a2313e8 100644 --- a/app/src/main/java/org/fdroid/fdroid/installer/DefaultInstaller.java +++ b/app/src/main/java/org/fdroid/fdroid/installer/DefaultInstaller.java @@ -50,8 +50,9 @@ public class DefaultInstaller extends Installer { @Override protected void installPackageInternal(Uri localApkUri, Uri canonicalUri) { - // ask to enable unknown sources on old Android versions - if (Build.VERSION.SDK_INT >= 26 && Build.VERSION.SDK_INT < 31) { + // ask to enable unknown sources on old Android versions (needs to target at least 26 for this to work) + if (Build.VERSION.SDK_INT >= 26 && Build.VERSION.SDK_INT < 31 && + context.getApplicationInfo().targetSdkVersion >= 26) { if (!context.getPackageManager().canRequestPackageInstalls()) { Intent i = new Intent(Settings.ACTION_MANAGE_UNKNOWN_APP_SOURCES); i.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);