From af4de1217eca5005b374d04ea67af4e3530daaff Mon Sep 17 00:00:00 2001 From: Tobias_Groza <304016-Tobias_Groza@noreply.gitlab.com> Date: Mon, 2 Sep 2024 20:11:35 +0200 Subject: [PATCH] Remove unnecessary null check canAndWantToUpdate returns false if suggestedApk is null --- .../org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java index 1f0965f50..a680edc13 100644 --- a/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java +++ b/app/src/main/java/org/fdroid/fdroid/views/AppDetailsRecyclerViewAdapter.java @@ -665,7 +665,7 @@ public class AppDetailsRecyclerViewAdapter buttonPrimaryView.setEnabled(true); buttonPrimaryView.setOnClickListener(v -> callbacks.installApk(suggestedApk)); } else if (app.isInstalled(context)) { - if (app.canAndWantToUpdate(suggestedApk) && suggestedApk != null) { + if (app.canAndWantToUpdate(suggestedApk)) { buttonPrimaryView.setText(R.string.menu_upgrade); buttonPrimaryView.setOnClickListener(v -> callbacks.installApk(suggestedApk)); } else {