move HttpDownloaderTest to emulator, AndroidOS has oddities

There are oddities with the way that Android has implemented the network stack, as compared to OpenJDK or Oracle JDK. So running the tests on the local JVM, i.e. Robolectric, will not provide good test coverage for real world use cases.
2026-06-17 20:29:34 -04:00 · 2016-09-27 14:40:53 +02:00
parent 0433f0eba5
commit bad613fbc1
1 changed files with 0 additions and 0 deletions
--- a/app/src/androidTest/java/org/fdroid/fdroid/net/HttpDownloaderTest.java
+++ b/app/src/androidTest/java/org/fdroid/fdroid/net/HttpDownloaderTest.java
@@ -0,0 +1,142 @@
+
+package org.fdroid.fdroid.net;
+
+import org.fdroid.fdroid.ProgressListener;
+import org.junit.Test;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URL;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
+
+public class HttpDownloaderTest {
+
+    String[] urls = {
+            "https://en.wikipedia.org/wiki/Index.html",
+            "https://mirrors.kernel.org/debian/dists/stable/Release",
+            "https://f-droid.org/repo/index.jar",
+            // sites that use SNI for HTTPS
+            "https://guardianproject.info/fdroid/repo/index.jar",
+    };
+
+    private boolean receivedProgress;
+
+    @Test
+    public void downloadUninterruptedTest() throws IOException, InterruptedException {
+        for (String urlString : urls) {
+            URL url = new URL(urlString);
+            File destFile = File.createTempFile("dl-", "");
+            HttpDownloader httpDownloader = new HttpDownloader(url, destFile);
+            httpDownloader.download();
+            assertTrue(destFile.exists());
+            assertTrue(destFile.canRead());
+            destFile.deleteOnExit();
+        }
+    }
+
+    @Test
+    public void downloadUninterruptedTestWithProgress() throws IOException, InterruptedException {
+        final CountDownLatch latch = new CountDownLatch(1);
+        String urlString = "https://f-droid.org/repo/index.jar";
+        receivedProgress = false;
+        System.out.println("downloadUninterruptedTestWithProgress: " + urlString);
+        receivedProgress = false;
+        URL url = new URL(urlString);
+        File destFile = File.createTempFile("dl-", "");
+        final HttpDownloader httpDownloader = new HttpDownloader(url, destFile);
+        httpDownloader.setListener(new ProgressListener() {
+            @Override
+            public void onProgress(URL sourceUrl, int bytesRead, int totalBytes) {
+                System.out.println("DownloaderProgressListener.sendProgress " + sourceUrl + " " + bytesRead + " / " + totalBytes);
+                receivedProgress = true;
+            }
+        });
+        new Thread() {
+            @Override
+            public void run() {
+                try {
+                    httpDownloader.download();
+                    latch.countDown();
+                } catch (IOException | InterruptedException e) {
+                    e.printStackTrace();
+                    fail();
+                }
+            }
+        }.start();
+        latch.await(100, TimeUnit.SECONDS); // either 2 progress reports or 100 seconds
+        assertTrue(destFile.exists());
+        assertTrue(destFile.canRead());
+        assertTrue(receivedProgress);
+        destFile.deleteOnExit();
+    }
+
+    @Test
+    public void downloadHttpBasicAuth() throws IOException, InterruptedException {
+        URL url = new URL("https://httpbin.org/basic-auth/myusername/supersecretpassword");
+        File destFile = File.createTempFile("dl-", "");
+        HttpDownloader httpDownloader = new HttpDownloader(url, destFile, "myusername", "supersecretpassword");
+        httpDownloader.download();
+        assertTrue(destFile.exists());
+        assertTrue(destFile.canRead());
+        destFile.deleteOnExit();
+    }
+
+    @Test(expected = IOException.class)
+    public void downloadHttpBasicAuthWrongPassword() throws IOException, InterruptedException {
+        URL url = new URL("https://httpbin.org/basic-auth/myusername/supersecretpassword");
+        File destFile = File.createTempFile("dl-", "");
+        HttpDownloader httpDownloader = new HttpDownloader(url, destFile, "myusername", "wrongpassword");
+        httpDownloader.download();
+        assertFalse(destFile.exists());
+        destFile.deleteOnExit();
+    }
+
+    @Test(expected = IOException.class)
+    public void downloadHttpBasicAuthWrongUsername() throws IOException, InterruptedException {
+        URL url = new URL("https://httpbin.org/basic-auth/myusername/supersecretpassword");
+        File destFile = File.createTempFile("dl-", "");
+        HttpDownloader httpDownloader = new HttpDownloader(url, destFile, "wrongusername", "supersecretpassword");
+        httpDownloader.download();
+        assertFalse(destFile.exists());
+        destFile.deleteOnExit();
+    }
+
+    @Test
+    public void downloadThenCancel() throws IOException, InterruptedException {
+        final CountDownLatch latch = new CountDownLatch(2);
+        URL url = new URL("https://f-droid.org/repo/index.jar");
+        File destFile = File.createTempFile("dl-", "");
+        final HttpDownloader httpDownloader = new HttpDownloader(url, destFile);
+        httpDownloader.setListener(new ProgressListener() {
+            @Override
+            public void onProgress(URL sourceUrl, int bytesRead, int totalBytes) {
+                System.out.println("DownloaderProgressListener.sendProgress " + bytesRead + " / " + totalBytes);
+                receivedProgress = true;
+                latch.countDown();
+            }
+        });
+        new Thread() {
+            @Override
+            public void run() {
+                try {
+                    httpDownloader.download();
+                    fail();
+                } catch (IOException e) {
+                    e.printStackTrace();
+                    fail();
+                } catch (InterruptedException e) {
+                    // success!
+                }
+            }
+        }.start();
+        latch.await(100, TimeUnit.SECONDS); // either 2 progress reports or 100 seconds
+        httpDownloader.cancelDownload();
+        assertTrue(receivedProgress);
+        destFile.deleteOnExit();
+    }
+}