proletarius101
f992d2c265
feat: add PMD linting integration to GitLab CI
2025-10-21 12:11:53 +00:00
Hans-Christoph Steiner
2828bf1f9f
-Pstrict.release build flag to disable dev tools
...
Keep the release build as small as possible, so it is faster. This also
makes it less important to track all the dev tool projects for security
issues, since they are disabled on release builds.
2022-12-20 20:59:59 +01:00
Hans-Christoph Steiner
3b67aa1a60
modernize PMD setup
2020-01-10 16:27:58 +01:00
Peter Serwylo
4e73d1e5e6
Finish porting tests to Robolectric, and appease PMD.
...
To appease PMD, we now have a three rulesets in `config/pmd/*.xml`:
* `rules.xml`: The bulk of the rules, used by both main and test code.
* `rules-main.xml`: Rules specific to the andoid client code.
* `rules-test.xml`: Rules specific to test code.
The rationale is because checkstyle by default checks for "too many static
imports", which is a fair call. However in JUnit4 code, it is common to
import many `assert*` static methods.
2016-06-09 10:44:40 +10:00
Daniel Martí
c432bf1ea0
PMD: Enable most empty code rules
2016-05-12 13:34:20 +01:00
Daniel Martí
65e2931fe8
PMD: Enable UnnecessaryWrapperObjectCreation
2016-05-12 13:34:20 +01:00
Hans-Christoph Steiner
7fbdfaaae7
enable PMD's java-basic ruleset
...
* CollapsibleIfStatements is pedantic
* that one NOPMD is for debug logging, it'll go away
closes #623 https://gitlab.com/fdroid/fdroidclient/issues/623
2016-05-12 09:36:08 +02:00
Daniel Martí
023a6d01bd
PMD: Enable some extra boolean/logic rules
2016-04-29 19:22:30 +01:00
Daniel Martí
ac8d3ff600
PMD: Enable and obey UnnecessaryParentheses
...
This works on statements, not expressions, so it's a lot easier and
saner to obey than UselessParentheses.
2016-04-29 19:22:04 +01:00
Daniel Martí
e5bc365b64
PMD: Enable a bunch of strictexception rules
...
We already obey them.
2016-04-28 17:17:17 +01:00
Daniel Martí
50b2e6f7a5
PMD: Enable and obey SingularField
2016-04-23 17:27:22 +01:00
Daniel Martí
68db3ae353
PMD: Enable and obey ImmutableField
2016-04-23 17:27:22 +01:00
Daniel Martí
c746a49b15
PMD: Enable some design.xml rules we already obey
2016-04-23 17:27:22 +01:00
Daniel Martí
f655f49aee
PMD: Enable and obey UnnecessaryConstructor
2016-04-23 16:17:55 +01:00
Daniel Martí
857b0ea1c7
PMD: Enable and obey AddEmptyString
2016-04-23 16:14:05 +01:00
Daniel Martí
5d3d8786e2
PMD: Enable and obey PrematureDeclaration
2016-04-23 16:06:41 +01:00
Daniel Martí
32c67d05ec
PMD: XML config file, enable most of unnecessary
2016-04-23 15:59:04 +01:00