From 2d1e0be98816370fc9173db5faec02515365fd41 Mon Sep 17 00:00:00 2001 From: linsui <2873532-linsui@users.noreply.gitlab.com> Date: Mon, 19 Jan 2026 21:53:36 +0800 Subject: [PATCH] fix E721 type-comparison --- fdroidserver/common.py | 4 ++-- fdroidserver/deploy.py | 2 +- fdroidserver/lint.py | 2 +- fdroidserver/metadata.py | 2 +- fdroidserver/update.py | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fdroidserver/common.py b/fdroidserver/common.py index 5de346c6..b8392e5b 100644 --- a/fdroidserver/common.py +++ b/fdroidserver/common.py @@ -904,7 +904,7 @@ def parse_human_readable_size(size): try: return int(float(size)) except (ValueError, TypeError) as exc: - if type(size) != str: + if type(size) is not str: raise ValueError( _('Could not parse size "{size}", wrong type "{type}"').format( size=size, type=type(size) @@ -2516,7 +2516,7 @@ def is_strict_application_id(name): def parse_srclib_spec(spec): - if type(spec) != str: + if type(spec) is not str: raise MetaDataException( _("can not parse scrlib spec (not a string): '{}'").format(spec) ) diff --git a/fdroidserver/deploy.py b/fdroidserver/deploy.py index d5380637..15c80896 100644 --- a/fdroidserver/deploy.py +++ b/fdroidserver/deploy.py @@ -998,7 +998,7 @@ def upload_to_github_releases_repo(repo_conf, release_infos, global_gh_token): ) return conf_package_names = repo_conf.get("packageNames", []) - if type(conf_package_names) == str: + if type(conf_package_names) is str: conf_package_names = [conf_package_names] if not conf_package_names: logging.warning( diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py index 66bc6505..3c3bd3b8 100644 --- a/fdroidserver/lint.py +++ b/fdroidserver/lint.py @@ -2360,7 +2360,7 @@ def lint_config(arg): if type(data[key]) not in (str, list, dict): passed = False show_error = True - elif type(data[key]) != t: + elif type(data[key]) is not t: passed = False show_error = True if show_error: diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py index 385d1408..10302ce2 100644 --- a/fdroidserver/metadata.py +++ b/fdroidserver/metadata.py @@ -390,7 +390,7 @@ class FieldValidator: def check(self, v, appid): if not v: return - if type(v) == list: + if type(v) is list: values = v else: values = [v] diff --git a/fdroidserver/update.py b/fdroidserver/update.py index f6943a7a..0a9762fe 100644 --- a/fdroidserver/update.py +++ b/fdroidserver/update.py @@ -973,7 +973,7 @@ def insert_funding_yml_donation_links(apps): ) ) logging.error(e) - if not data or type(data) != dict: + if not data or type(data) is not dict: continue if not app.get('Liberapay') and 'liberapay' in data: s = sanitize_funding_yml_name(data['liberapay'])